Skip to content

Commit 79d099d

Browse files
authored
chore: remove codestyle workflow filter (#69)
* chore: remove codestyle workflow filter * fix redis test
1 parent dec895d commit 79d099d

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

.github/workflows/codestyle.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
name: codestyle
22
on:
33
pull_request:
4-
paths:
5-
- "!*.md"
64
workflow_dispatch:
75
jobs:
86
code-coverage:

tests/RedisSequenceResolverTest.php

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
namespace Tests;
1414

1515
use Godruoyi\Snowflake\RedisSequenceResolver;
16+
use Godruoyi\Snowflake\Snowflake;
1617
use RedisException;
1718

1819
class RedisSequenceResolverTest extends TestCase
@@ -75,15 +76,19 @@ public function test_real_redis(): void
7576
$redis = new \Redis();
7677
$redis->connect($host, $port | 0);
7778

79+
// Sometimes running these tests in parallel on Github may cause unexpected errors,
80+
// so we change to use random here.
81+
$key = (new Snowflake())->getCurrentMillisecond();
82+
7883
$redisResolver = new RedisSequenceResolver($redis);
7984

80-
$this->assertEquals(0, $redisResolver->sequence(1));
81-
$this->assertEquals(1, $redisResolver->sequence(1));
82-
$this->assertEquals(2, $redisResolver->sequence(1));
83-
$this->assertEquals(3, $redisResolver->sequence(1));
85+
$this->assertEquals(0, $redisResolver->sequence($key));
86+
$this->assertEquals(1, $redisResolver->sequence($key));
87+
$this->assertEquals(2, $redisResolver->sequence($key));
88+
$this->assertEquals(3, $redisResolver->sequence($key));
8489

8590
sleep(10);
8691

87-
$this->assertEquals(0, $redisResolver->sequence(1));
92+
$this->assertEquals(0, $redisResolver->sequence($key));
8893
}
8994
}

0 commit comments

Comments
 (0)