Skip to content

Prepare to migrate to NHCB by updating mixins #13400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Prepare to migrate to NHCB by updating mixins #13400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1511bf
Enable NHCB in docker-compose
zenador Nov 7, 2025
7ced9de
Update some metrics in dashboards and recording rules and alert to us…
zenador Nov 7, 2025
26c2f56
make build-helm-tests
zenador Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions development/mimir-microservices-mode/config/mimir.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,3 +198,6 @@ limits:

runtime_config:
file: ./config/runtime.yaml

server:
log_level: error
Copy link
Contributor

@krajorama krajorama Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be annoying for people, lets not do it. We can turn it on on demand.

2 changes: 2 additions & 0 deletions development/mimir-microservices-mode/config/prometheus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ global:
scrape_interval: 5s
external_labels:
scraped_by: prometheus
convert_classic_histograms_to_nhcb: true
always_scrape_classic_histograms: true

scrape_configs:
Expand Down Expand Up @@ -47,6 +48,7 @@ remote_write:
- url: http://distributor-1:8000/api/v1/push
send_native_histograms: true
send_exemplars: true
protobuf_message: "io.prometheus.write.v2.Request"

rule_files:
- '/etc/mixin/mimir-alerts.yaml'
Expand Down
2 changes: 1 addition & 1 deletion development/mimir-microservices-mode/docker-compose.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ std.manifestYamlDoc({

prometheus:: {
prometheus: {
image: 'prom/prometheus:v3.5.0',
image: 'prom/prometheus:v3.6.0',
Copy link
Contributor

@krajorama krajorama Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we have 3.7.3 latest

command: [
'--config.file=/etc/prometheus/prometheus.yaml',
'--enable-feature=exemplar-storage',
Expand Down
2 changes: 1 addition & 1 deletion development/mimir-microservices-mode/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@
- "--config.file=/etc/prometheus/prometheus.yaml"
- "--enable-feature=exemplar-storage"
- "--enable-feature=native-histograms"
"image": "prom/prometheus:v3.5.0"
"image": "prom/prometheus:v3.6.0"
"ports":
- "9090:9090"
"volumes":
Expand Down
3,413 changes: 2,852 additions & 561 deletions ...oring-values-generated/mimir-distributed/templates/metamonitoring/grafana-dashboards.yaml
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 16 additions & 0 deletions ...amonitoring-values-generated/mimir-distributed/templates/metamonitoring/mixin-alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,22 @@ spec:
for: 5m
labels:
severity: critical
- alert: MimirKVStoreFailureNativeHistogram
annotations:
message: |
Mimir {{ $labels.pod }} in {{ $labels.cluster }}/{{ $labels.namespace }} is failing to talk to the KV store {{ $labels.kv_name }}.
runbook_url: https://grafana.com/docs/mimir/latest/operators-guide/mimir-runbooks/#mimirkvstorefailurenativehistogram
expr: |
(
sum by(cluster, namespace, pod, status_code, kv_name) (histogram_count(rate(cortex_kv_request_duration_seconds{status_code!~"2.+"}[1m])))
/
sum by(cluster, namespace, pod, status_code, kv_name) (histogram_count(rate(cortex_kv_request_duration_seconds[1m])))
)
# We want to get alerted only in case there's a constant failure.
== 1
for: 5m
labels:
severity: critical
- alert: MimirMemoryMapAreasTooHigh
annotations:
message: '{{ $labels.job }}/{{ $labels.pod }} has a number of mmap-ed areas close to the limit.'
Expand Down
18 changes: 18 additions & 0 deletions ...nitoring-values-generated/mimir-distributed/templates/metamonitoring/recording-rules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ spec:
record: cluster_job:cortex_querier_request_duration_seconds_sum:sum_rate
- expr: sum(rate(cortex_querier_request_duration_seconds_count[1m])) by (cluster, job)
record: cluster_job:cortex_querier_request_duration_seconds_count:sum_rate
- expr: sum(rate(cortex_querier_request_duration_seconds[1m])) by (cluster, job)
record: cluster_job:cortex_querier_request_duration_seconds:sum_rate
- expr: histogram_quantile(0.99, sum(rate(cortex_querier_request_duration_seconds_bucket[1m])) by (le, cluster, job, route))
record: cluster_job_route:cortex_querier_request_duration_seconds:99quantile
- expr: histogram_quantile(0.50, sum(rate(cortex_querier_request_duration_seconds_bucket[1m])) by (le, cluster, job, route))
Expand All @@ -85,6 +87,8 @@ spec:
record: cluster_job_route:cortex_querier_request_duration_seconds_sum:sum_rate
- expr: sum(rate(cortex_querier_request_duration_seconds_count[1m])) by (cluster, job, route)
record: cluster_job_route:cortex_querier_request_duration_seconds_count:sum_rate
- expr: sum(rate(cortex_querier_request_duration_seconds[1m])) by (cluster, job, route)
record: cluster_job_route:cortex_querier_request_duration_seconds:sum_rate
- expr: histogram_quantile(0.99, sum(rate(cortex_querier_request_duration_seconds_bucket[1m])) by (le, cluster, namespace, job, route))
record: cluster_namespace_job_route:cortex_querier_request_duration_seconds:99quantile
- expr: histogram_quantile(0.50, sum(rate(cortex_querier_request_duration_seconds_bucket[1m])) by (le, cluster, namespace, job, route))
Expand All @@ -97,6 +101,8 @@ spec:
record: cluster_namespace_job_route:cortex_querier_request_duration_seconds_sum:sum_rate
- expr: sum(rate(cortex_querier_request_duration_seconds_count[1m])) by (cluster, namespace, job, route)
record: cluster_namespace_job_route:cortex_querier_request_duration_seconds_count:sum_rate
- expr: sum(rate(cortex_querier_request_duration_seconds[1m])) by (cluster, namespace, job, route)
record: cluster_namespace_job_route:cortex_querier_request_duration_seconds:sum_rate
- name: mimir_storage
rules:
- expr: histogram_quantile(0.99, sum(rate(cortex_kv_request_duration_seconds_bucket[1m])) by (le, cluster, job))
Expand All @@ -111,6 +117,8 @@ spec:
record: cluster_job:cortex_kv_request_duration_seconds_sum:sum_rate
- expr: sum(rate(cortex_kv_request_duration_seconds_count[1m])) by (cluster, job)
record: cluster_job:cortex_kv_request_duration_seconds_count:sum_rate
- expr: sum(rate(cortex_kv_request_duration_seconds[1m])) by (cluster, job)
record: cluster_job:cortex_kv_request_duration_seconds:sum_rate
- name: mimir_queries
rules:
- expr: histogram_quantile(0.99, sum(rate(cortex_query_frontend_retries_bucket[1m])) by (le, cluster, job))
Expand All @@ -125,6 +133,8 @@ spec:
record: cluster_job:cortex_query_frontend_retries_sum:sum_rate
- expr: sum(rate(cortex_query_frontend_retries_count[1m])) by (cluster, job)
record: cluster_job:cortex_query_frontend_retries_count:sum_rate
- expr: sum(rate(cortex_query_frontend_retries[1m])) by (cluster, job)
record: cluster_job:cortex_query_frontend_retries:sum_rate
- expr: histogram_quantile(0.99, sum(rate(cortex_query_frontend_queue_duration_seconds_bucket[1m])) by (le, cluster, job))
record: cluster_job:cortex_query_frontend_queue_duration_seconds:99quantile
- expr: histogram_quantile(0.50, sum(rate(cortex_query_frontend_queue_duration_seconds_bucket[1m])) by (le, cluster, job))
Expand All @@ -137,6 +147,8 @@ spec:
record: cluster_job:cortex_query_frontend_queue_duration_seconds_sum:sum_rate
- expr: sum(rate(cortex_query_frontend_queue_duration_seconds_count[1m])) by (cluster, job)
record: cluster_job:cortex_query_frontend_queue_duration_seconds_count:sum_rate
- expr: sum(rate(cortex_query_frontend_queue_duration_seconds[1m])) by (cluster, job)
record: cluster_job:cortex_query_frontend_queue_duration_seconds:sum_rate
- name: mimir_ingester_queries
rules:
- expr: histogram_quantile(0.99, sum(rate(cortex_ingester_queried_series_bucket[1m])) by (le, cluster, job))
Expand All @@ -151,6 +163,8 @@ spec:
record: cluster_job:cortex_ingester_queried_series_sum:sum_rate
- expr: sum(rate(cortex_ingester_queried_series_count[1m])) by (cluster, job)
record: cluster_job:cortex_ingester_queried_series_count:sum_rate
- expr: sum(rate(cortex_ingester_queried_series[1m])) by (cluster, job)
record: cluster_job:cortex_ingester_queried_series:sum_rate
- expr: histogram_quantile(0.99, sum(rate(cortex_ingester_queried_samples_bucket[1m])) by (le, cluster, job))
record: cluster_job:cortex_ingester_queried_samples:99quantile
- expr: histogram_quantile(0.50, sum(rate(cortex_ingester_queried_samples_bucket[1m])) by (le, cluster, job))
Expand All @@ -163,6 +177,8 @@ spec:
record: cluster_job:cortex_ingester_queried_samples_sum:sum_rate
- expr: sum(rate(cortex_ingester_queried_samples_count[1m])) by (cluster, job)
record: cluster_job:cortex_ingester_queried_samples_count:sum_rate
- expr: sum(rate(cortex_ingester_queried_samples[1m])) by (cluster, job)
record: cluster_job:cortex_ingester_queried_samples:sum_rate
- expr: histogram_quantile(0.99, sum(rate(cortex_ingester_queried_exemplars_bucket[1m])) by (le, cluster, job))
record: cluster_job:cortex_ingester_queried_exemplars:99quantile
- expr: histogram_quantile(0.50, sum(rate(cortex_ingester_queried_exemplars_bucket[1m])) by (le, cluster, job))
Expand All @@ -175,6 +191,8 @@ spec:
record: cluster_job:cortex_ingester_queried_exemplars_sum:sum_rate
- expr: sum(rate(cortex_ingester_queried_exemplars_count[1m])) by (cluster, job)
record: cluster_job:cortex_ingester_queried_exemplars_count:sum_rate
- expr: sum(rate(cortex_ingester_queried_exemplars[1m])) by (cluster, job)
record: cluster_job:cortex_ingester_queried_exemplars:sum_rate
- name: mimir_received_samples
rules:
- expr: |
Expand Down
16 changes: 16 additions & 0 deletions operations/mimir-mixin-compiled-baremetal/alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,22 @@ groups:
for: 5m
labels:
severity: critical
- alert: MimirKVStoreFailureNativeHistogram
annotations:
message: |
Mimir {{ $labels.instance }} in {{ $labels.cluster }}/{{ $labels.namespace }} is failing to talk to the KV store {{ $labels.kv_name }}.
runbook_url: https://grafana.com/docs/mimir/latest/operators-guide/mimir-runbooks/#mimirkvstorefailurenativehistogram
expr: |
(
sum by(cluster, namespace, instance, status_code, kv_name) (histogram_count(rate(cortex_kv_request_duration_seconds{status_code!~"2.+"}[1m])))
/
sum by(cluster, namespace, instance, status_code, kv_name) (histogram_count(rate(cortex_kv_request_duration_seconds[1m])))
)
# We want to get alerted only in case there's a constant failure.
== 1
for: 5m
labels:
severity: critical
- alert: MimirMemoryMapAreasTooHigh
annotations:
message: '{{ $labels.job }}/{{ $labels.instance }} has a number of mmap-ed areas close to the limit.'
Expand Down
Loading
Loading