Skip to content

Commit 37fee58

Browse files
committed
fix flaky test
1 parent a33609a commit 37fee58

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

pkg/collector/distinct_string_collector_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ func TestDistinctStringCollector(t *testing.T) {
1818
d.Collect("11")
1919

2020
require.True(t, d.Exceeded())
21-
require.Equal(t, []string{"123", "4567", "890"}, d.Strings())
21+
stringsSlicesEqual(t, []string{"123", "4567", "890"}, d.Strings())
2222

2323
// diff fails when diff is not enabled
2424
res, err := d.Diff()
@@ -32,14 +32,14 @@ func TestDistinctStringCollectorDiff(t *testing.T) {
3232
d.Collect("123")
3333
d.Collect("4567")
3434

35-
require.Equal(t, []string{"123", "4567"}, readDistinctStringDiff(t, d))
36-
require.Equal(t, []string{}, readDistinctStringDiff(t, d))
35+
stringsSlicesEqual(t, []string{"123", "4567"}, readDistinctStringDiff(t, d))
36+
stringsSlicesEqual(t, []string{}, readDistinctStringDiff(t, d))
3737

3838
d.Collect("123")
3939
d.Collect("890")
4040

41-
require.Equal(t, []string{"890"}, readDistinctStringDiff(t, d))
42-
require.Equal(t, []string{}, readDistinctStringDiff(t, d))
41+
stringsSlicesEqual(t, []string{"890"}, readDistinctStringDiff(t, d))
42+
stringsSlicesEqual(t, []string{}, readDistinctStringDiff(t, d))
4343
}
4444

4545
func readDistinctStringDiff(t *testing.T, d *DistinctString) []string {

pkg/collector/distinct_value_collector_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func TestDistinctValueCollector(t *testing.T) {
2323

2424
require.True(t, d.Exceeded())
2525
require.Equal(t, stop, d.Exceeded()) // final stop should be same as Exceeded
26-
require.Equal(t, []string{"123", "4567"}, d.Values())
26+
stringsSlicesEqual(t, []string{"123", "4567"}, d.Values())
2727

2828
// diff fails when diff is not enabled
2929
res, err := d.Diff()

0 commit comments

Comments
 (0)