Skip to content

Update decimation api #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jo-mueller wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Update decimation api #91

jo-mueller wants to merge 21 commits into from

Conversation

@jo-mueller
Copy link
Collaborator

@jo-mueller jo-mueller commented May 13, 2024

Fixes #90

Hi @haesleinhuepf , this PR fixes the call to the decimate_pro function of vedo (formerly known as decimate(method='pro', ...).

  • Tested interactively from napari viewer
  • Unit tests are passing locally

This PR is based on PR #88 to go first.

Best, Johannes

@jo-mueller
replaced .points() with .vertices
c59f5e0
@jo-mueller
fixed call to deprecated ._data
7060575
@jo-mueller
replaced call to faces()` with cells`
d409e92
@jo-mueller
replaced deprecated compute_connectivity
723ae03
@jo-mueller
update vedo version
747c9d5
@jo-mueller
removed __main__
bcdb609
@jo-mueller
re-introduced connected-components labelling
5bf3823
@jo-mueller
Introduced split-mesh function according to new vedo API
f4d2148
@jo-mueller
Added mention of both functionality (connected components & split) to…
92cd994 
… docs
@jo-mueller
added test coverage for both
bc99d09
@jo-mueller
fixed test
1d81b06
@jo-mueller
Changed connected components labelling function name to original
4bcdd92
@jo-mueller
removed unused __main__
0826bb1
@jo-mueller
removed deprecated origin display
0ae5a7b
@jo-mueller
fixed call to quadric decimation
bd3785c
@jo-mueller
updated version pin for vedo
641ca5a
@jo-mueller
Merge branch 'fix-vedo-API' into update-decimation-API
c905573
@jo-mueller
Revert "Merge branch 'fix-vedo-API' into update-decimation-API"
0e62b6e 
This reverts commit c905573, reversing
changes made to 641ca5a.
@jo-mueller
Reapply "Merge branch 'fix-vedo-API' into update-decimation-API"
c4f6dc6 
This reverts commit 0e62b6e.
@jo-mueller
reran notebook
af3964d
@jo-mueller
fixed call to progressive decimation
0ab12aa
@jo-mueller jo-mueller added the bug Something isn't working label May 13, 2024
@jo-mueller jo-mueller mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Decimation API changed

1 participant

@jo-mueller