UI/ember upgrade to v4.12 (#23070)

* all tests fixed

* code cleanup

* fix minor issue

* adds changelog

* remove redundant fn usage

* fixes assert equal issues

* ppnpm lock update

* avoid crashing on error

* fixes lint issue

* revert

* test change

* fix torii provider baseUrl assertion without changing SSO flow

* linting fix

* route import change

* minor fixes

* added required parameter @type to hds:alert

* fixes some browser error logs

* lint fixes

Author: rishabh-gupta-hashicorp

.changelog/23070.txt

@@ -0,0 +1,3 @@
+```release-note:improvement
+ui: upgraded Ember framework from v3.28 to v4.12, improving performance and stability. Upgrades multiple other packages which support Ember v4.
+```

ui/packages/consul-lock-sessions/app/components/consul/lock-session/form/index.hbs

@@ -17,8 +17,8 @@
         dc=@item.Datacenter
       )
     }}
-    @type={{'session'}}
-    @label={{'Lock Session'}}
+    @type='session'
+    @label='Lock Session'
     @ondelete={{fn (if @ondelete @ondelete @onsubmit) @item}}
     @onchange={{fn (optional @onsubmit) @item}}
     as |writer|>
@@ -86,7 +86,7 @@
               @text='Invalidate Session'
               @color='critical'
               data-test-delete
-              {{on 'click' (fn confirm )}}
+              {{on 'click' confirm }}
             />
           </BlockSlot>
           <BlockSlot @name="dialog" as |execute cancel message|>
@@ -103,7 +103,7 @@
               <Hds::Button
                 @text='Cancel'
                 @color='secondary'
-                {{on 'click' (fn cancel)}}
+                {{on 'click' cancel}}
               />
             </Hds::ButtonSet>
           </BlockSlot>

ui/packages/consul-lock-sessions/app/components/consul/lock-session/list/index.hbs

@@ -107,7 +107,7 @@ as |item index|>
           <Hds::Button
             @text='Cancel'
             @color='secondary'
-            {{on 'click' (fn cancel)}}
+            {{on 'click' cancel}}
           />
         </Hds::ButtonSet>
       </BlockSlot>

ui/packages/consul-nspaces/app/components/consul/nspace/form/index.hbs

@@ -9,8 +9,8 @@
       "/${partition}/${nspace}/${dc}/nspace"
       (hash partition="" nspace="" dc=@item.Datacenter)
     }}
-    @type={{"nspace"}}
-    @label={{"Namespace"}}
+    @type="nspace"
+    @label="Namespace"
     @ondelete={{fn this.onDelete @item}}
     @onchange={{fn this.onSubmit @item}}
     as |writer|
@@ -145,7 +145,7 @@
                       data-test-delete
                       @color='critical'
                       @text='Delete'
-                      {{on "click" (fn confirm )}}
+                      {{on "click" confirm }}
                     />
                   </BlockSlot>
                   <BlockSlot @name="dialog" as |execute cancel message|>

ui/packages/consul-nspaces/app/templates/dc/nspaces/edit.hbs

@@ -4,7 +4,7 @@
 }}
 
 <Route
-  @name={{routeName}}
+  @name={{this.routeName}}
 as |route|>
   <DataLoader @src={{
     uri '/${partition}/${nspace}/${dc}/namespace/${id}'

ui/packages/consul-nspaces/app/templates/dc/nspaces/index.hbs

@@ -4,7 +4,7 @@
 }}
 
 <Route
-  @name={{routeName}}
+  @name={{this.routeName}}
 as |route|>
   <DataLoader
     @src={{
@@ -27,18 +27,18 @@ as |route|>
   {{#let
 
     (hash
-      value=(or sortBy "Name:asc")
-      change=(action (mut sortBy) value="target.selected")
+      value=(or this.sortBy "Name:asc")
+      change=(action (mut this.sortBy) value="target.selected")
     )
 
     (hash
       searchproperty=(hash
-        value=(if (not-eq searchproperty undefined)
-          (split searchproperty ',')
-          searchProperties
+        value=(if (not-eq this.searchproperty undefined)
+          (split this.searchproperty ',')
+          this.searchProperties
         )
-        change=(action (mut searchproperty) value="target.selectedItems")
-        default=searchProperties
+        change=(action (mut this.searchproperty) value="target.selectedItems")
+        default=this.searchProperties
       )
     )
 
@@ -64,8 +64,8 @@ as |route|>
       <BlockSlot @name="toolbar">
       {{#if (gt items.length 0)}}
         <Consul::Nspace::SearchBar
-          @search={{search}}
-          @onsearch={{action (mut search) value="target.value"}}
+          @search={{this.search}}
+          @onsearch={{action (mut this.search) value="target.value"}}
 
           @sort={{sort}}
 
@@ -100,7 +100,7 @@ as |route|>
           @type="nspace"
           @sort={{sort.value}}
           @filters={{filters}}
-          @search={{search}}
+          @search={{this.search}}
           @items={{items}}
         as |collection|>
           <collection.Collection>

ui/packages/consul-partitions/app/components/consul/partition/form/index.hbs

@@ -16,8 +16,8 @@
           dc=@item.Datacenter
         )
       }}
-      @type={{'partition'}}
-      @label={{'Partition'}}
+      @type='partition'
+      @label='Partition'
       @ondelete={{fn (if @ondelete @ondelete @onsubmit) @item}}
       @onchange={{fn (optional @onsubmit) @item}}
       as |writer|>

ui/packages/consul-partitions/app/templates/dc/partitions/edit.hbs

@@ -4,7 +4,7 @@
 }}
 
 <Route
-  @name={{routeName}}
+  @name={{this.routeName}}
 as |route|>
   <DataLoader @src={{
     uri '/${partition}/${nspace}/${dc}/partition/${id}'

ui/packages/consul-partitions/app/templates/dc/partitions/index.hbs

@@ -4,7 +4,7 @@
 }}
 
 <Route
-  @name={{routeName}}
+  @name={{this.routeName}}
 as |route|>
   <DataLoader
     @src={{
@@ -27,18 +27,18 @@ as |route|>
   {{#let
 
     (hash
-      value=(or sortBy "Name:asc")
-      change=(action (mut sortBy) value="target.selected")
+      value=(or this.sortBy "Name:asc")
+      change=(action (mut this.sortBy) value="target.selected")
     )
 
     (hash
       searchproperty=(hash
-        value=(if (not-eq searchproperty undefined)
-          (split searchproperty ',')
-          searchProperties
+        value=(if (not-eq this.searchproperty undefined)
+          (split this.searchproperty ',')
+          this.searchProperties
         )
-        change=(action (mut searchproperty) value="target.selectedItems")
-        default=searchProperties
+        change=(action (mut this.searchproperty) value="target.selectedItems")
+        default=this.searchProperties
       )
     )
 
@@ -64,8 +64,8 @@ as |route|>
       <BlockSlot @name="toolbar">
       {{#if (gt items.length 0)}}
         <Consul::Partition::SearchBar
-          @search={{search}}
-          @onsearch={{action (mut search) value="target.value"}}
+          @search={{this.search}}
+          @onsearch={{action (mut this.search) value="target.value"}}
 
           @sort={{sort}}
 
@@ -100,7 +100,7 @@ as |route|>
           @type="nspace"
           @sort={{sort.value}}
           @filters={{filters}}
-          @search={{search}}
+          @search={{this.search}}
           @items={{items}}
         as |collection|>
           <collection.Collection>

ui/packages/consul-peerings/app/components/consul/peer/form/generate/index.hbs

@@ -13,12 +13,12 @@
     as |fsm|
   >
 
-    {{#let (unique-id) as |id reset|}}
+    {{#let (dom-guid) as |id reset|}}
       <form {{on "submit" (fn fsm.dispatch "LOAD")}} id={{id}}>
 
         <fsm.State @matches={{array "idle" "error"}}>
-          <fsm.State @matches={{"error"}}>
-            <Hds::Alert @color='critical' class='mb-3 mt-2' as |A|>
+          <fsm.State @matches="error">
+            <Hds::Alert @type="inline" @color='critical' class='mb-3 mt-2' as |A|>
               <A.Title>Error</A.Title>
               <A.Description>{{fsm.state.context.error.message}}</A.Description>
             </Hds::Alert>
@@ -35,7 +35,7 @@
           }}
         </fsm.State>
 
-        <fsm.State @matches={{"loading"}}>
+        <fsm.State @matches="loading">
           <DataSource
             @src={{uri
               "/${partition}/${nspace}/${dc}/peering/token-for/${name}/${externalAddresses}"
@@ -55,7 +55,7 @@
           />
         </fsm.State>
 
-        <fsm.State @matches={{"success"}}>
+        <fsm.State @matches="success">
           {{yield
             (hash
               Fieldsets=(component