feat(components): remove ember-get-config (#3277)

Author: aklkv

packages/components/addon-main.cjs

@@ -8,6 +8,7 @@ const flightIconSprite = require('@hashicorp/flight-icons/svg-sprite/svg-sprite-
 
 module.exports = {
   ...addonV1Shim(__dirname),
+
   contentFor(type, config) {
     if (
       !config.flightIconsSpriteLazyEmbed &&

packages/components/package.json

@@ -62,7 +62,6 @@
     "ember-concurrency": "^4.0.4",
     "ember-element-helper": "^0.8.6",
     "ember-focus-trap": "^1.1.1",
-    "ember-get-config": "^2.1.1",
     "ember-modifier": "^4.2.2",
     "ember-power-select": "^8.7.1",
     "ember-stargate": "^1.0.2",

packages/components/src/instance-initializers/load-sprite.ts

@@ -3,19 +3,27 @@
  * SPDX-License-Identifier: MPL-2.0
  */
 
-import config from 'ember-get-config';
+import { isTesting } from '@embroider/macros';
 
-export async function initialize() {
-  // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-  if (config?.flightIconsSpriteLazyEmbed) {
+import type ApplicationInstance from '@ember/application/instance';
+
+interface Config {
+  flightIconsSpriteLazyEmbed?: boolean;
+}
+
+export async function initialize(appInstance: ApplicationInstance) {
+  const config = appInstance.resolveRegistration(
+    'config:environment'
+  ) as Config;
+
+  if (config.flightIconsSpriteLazyEmbed) {
     const { default: svgSprite } = await import(
       '@hashicorp/flight-icons/svg-sprite/svg-sprite-module'
     );
 
     // in test environments we can inject the sprite directly into the ember testing container
     // to avoid issues with tools like Percy that only consider content inside that element
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-    if (config.environment === 'test') {
+    if (isTesting()) {
       const container = window.document?.getElementById('ember-testing');
 
       if (container && !container.querySelector('.flight-sprite-container')) {

packages/components/src/modifiers/hds-code-editor.ts

@@ -7,7 +7,7 @@ import Modifier from 'ember-modifier';
 import { assert, warn } from '@ember/debug';
 import { registerDestructor } from '@ember/destroyable';
 import { task } from 'ember-concurrency';
-import config from 'ember-get-config';
+import { macroCondition, isTesting } from '@embroider/macros';
 import { Compartment } from '@codemirror/state';
 import { EditorView } from '@codemirror/view';
 import { guidFor } from '@ember/object/internals';
@@ -208,8 +208,7 @@ export default class HdsCodeEditorModifier extends Modifier<HdsCodeEditorSignatu
     // if the editor does not exist, setup the editor
     else {
       // the intersection observer makes loading unreliable in tests
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-      if (config.environment === 'test') {
+      if (macroCondition(isTesting())) {
         // eslint-disable-next-line @typescript-eslint/no-floating-promises
         this._setupTask.perform(element, positional, named);
       } else {

pnpm-lock.yaml

@@ -101,7 +101,6 @@
     "ember-template-lint": "^7.7.0",
     "ember-truth-helpers": "^4.0.3",
     "ember-try": "^4.0.0",
-    "ember-unique-id-helper-polyfill": "^1.2.2",
     "eslint": "^9.27.0",
     "eslint-config-prettier": "^10.1.5",
     "eslint-plugin-ember": "^12.5.0",

showcase/package.json

@@ -1,6 +1,7 @@
 import Route from '@ember/routing/route';
 import fetch from 'fetch';
-import config from 'ember-get-config';
+
+import config from 'website/config/environment';
 
 export default class ApplicationRoute extends Route {
   model() {

website/app/routes/application.js

@@ -6,11 +6,12 @@ import {
   isUnauthorizedResponse,
   isNotFoundResponse,
 } from 'ember-fetch/errors';
-import config from 'ember-get-config';
 import { service } from '@ember/service';
 import { action } from '@ember/object';
 import { reject } from 'rsvp';
 
+import config from 'website/config/environment';
+
 export default class ShowRoute extends Route {
   @service router;
   queryParams = {

website/app/routes/show.js

@@ -4,9 +4,10 @@
  */
 
 import HeadDataService from 'ember-meta/services/head-data';
-import config from 'ember-get-config';
 import { service } from '@ember/service';
 
+import config from 'website/config/environment';
+
 export default class CustomHeadDataService extends HeadDataService {
   @service router;
 

website/app/services/head-data.js

@@ -90,7 +90,6 @@
     "ember-cli-terser": "^4.0.2",
     "ember-concurrency": "^4.0.4",
     "ember-fetch": "^8.1.2",
-    "ember-get-config": "^2.1.1",
     "ember-load-initializers": "^3.0.1",
     "ember-math-helpers": "^4.2.1",
     "ember-meta": "^2.0.0",