Complete the implementation of moving panics to the Error log level #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbardin
force-pushed
the
jbardin/panic-logging-cleanup
branch
from
0f18701 to
7769a89
Compare
jbardin
commented
Jul 18, 2025
|
|
||
| func TestClient_logger(t *testing.T) { | ||
| t.Run("net/rpc", func(t *testing.T) { testClient_logger(t, "netrpc") }) | ||
| t.Run("netrpc", func(t *testing.T) { testClient_logger(t, "netrpc") }) |
Member
Author
There was a problem hiding this comment.
This change is solely for test ergonomics, the extra / made it behave as a sub-sub-test.
mildwonkey
approved these changes
Jul 18, 2025
Member
Author
|
@hashicorp/team-ip-compliance, waiting on review please |
robmonte
reviewed
Aug 5, 2025
Member
robmonte
left a comment
robmonte
left a comment
There was a problem hiding this comment.
Looks great, just one question!
sonamtenzin2
previously approved these changes
Aug 7, 2025
Don't shadow the builtin `panic` symbol. Remove the redundant `false` assignments. Flatten the if block since we are already using a switch.
jbardin
force-pushed
the
jbardin/panic-logging-cleanup
branch
from
2b902c6 to
6a167cc
Compare
sonamtenzin2
previously approved these changes
Aug 7, 2025
It wasn't clear which versions of the protobuf tooling needed to be used to generate the test code, and updating them required some additional changes. Since the `buf` tool was adopted to generate the example code, use the same tool to make generating the test code easier too.
sonamtenzin2
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #292, we update the implementation slightly, but maintain the same behavior:
panicsymbol.Most clients won't notice the change, but some like Terraform must capture plugin stack traces in order to help users identify the source of the error. Changing the stream is a breaking change for Terraform, so updating to a new minor version will need to be coordinated with downstream consumers.