[WIP] Update deployment test - operator

Author: arybolovlev

charts/hcp-terraform-operator/values.yaml

@@ -56,7 +56,7 @@ operator:
   #         - key: kubernetes.io/arch
   #           operator: In
   #           values:
-  #         - amd64
+  #           - amd64
   #
   # -- Kubernetes Affinity. More information: https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity
   affinity: {}

charts/test/unit/deployment_test.go

@@ -268,14 +268,34 @@ func TestDeploymentOperatorImage(t *testing.T) {
 	assert.Equal(t, d, deployment)
 }
 
-// TODO
 func TestDeploymentOperatorResources(t *testing.T) {
 	options := &helm.Options{
+		SetJsonValues: map[string]string{
+			"operator.resources.limits": `{
+				"cpu": "2",
+				"memory": "512Mi"
+			}`,
+			"operator.resources.requests": `{
+				"cpu": "250m",
+				"memory": "128Mi"
+			}`,
+		},
 		Version: helmChartVersion,
 	}
 	deployment := renderDeploymentManifest(t, options)
 	d := defaultDeployment()
 
+	d.Spec.Template.Spec.Containers[0].Resources = corev1.ResourceRequirements{
+		Limits: corev1.ResourceList{
+			corev1.ResourceCPU:    resource.MustParse("2"),
+			corev1.ResourceMemory: resource.MustParse("512Mi"),
+		},
+		Requests: corev1.ResourceList{
+			corev1.ResourceCPU:    resource.MustParse("250m"),
+			corev1.ResourceMemory: resource.MustParse("128Mi"),
+		},
+	}
+
 	assert.Equal(t, d, deployment)
 }
 
@@ -290,25 +310,73 @@ func TestDeploymentOperatorSecurityContext(t *testing.T) {
 	assert.Equal(t, d, deployment)
 }
 
-// TODO
 func TestDeploymentOperatorAffinity(t *testing.T) {
 	options := &helm.Options{
+		SetJsonValues: map[string]string{
+			"operator.affinity": `{
+				"nodeAffinity": {
+					"requiredDuringSchedulingIgnoredDuringExecution": {
+						"nodeSelectorTerms": [{
+							"matchExpressions": [{
+								"key": "kubernetes.io/arch",
+								"operator": "In",
+								"values": ["amd64"]
+							}]
+						}]
+					}
+				}
+			}`,
+		},
 		Version: helmChartVersion,
 	}
 	deployment := renderDeploymentManifest(t, options)
 	d := defaultDeployment()
 
+	d.Spec.Template.Spec.Affinity = &corev1.Affinity{
+		NodeAffinity: &corev1.NodeAffinity{
+			RequiredDuringSchedulingIgnoredDuringExecution: &corev1.NodeSelector{
+				NodeSelectorTerms: []corev1.NodeSelectorTerm{
+					{
+						MatchExpressions: []corev1.NodeSelectorRequirement{
+							{
+								Key:      "kubernetes.io/arch",
+								Operator: corev1.NodeSelectorOpIn,
+								Values:   []string{"amd64"},
+							},
+						},
+					},
+				},
+			},
+		},
+	}
+
 	assert.Equal(t, d, deployment)
 }
 
-// TODO
 func TestDeploymentOperatorTolerations(t *testing.T) {
 	options := &helm.Options{
+		SetJsonValues: map[string]string{
+			"operator.tolerations": `[{
+				"key": "cloud.hashicorp.com/terraform",
+				"operator": "Equal",
+				"value": "operator",
+				"effect": "PreferNoSchedule"
+			}]`,
+		},
 		Version: helmChartVersion,
 	}
 	deployment := renderDeploymentManifest(t, options)
 	d := defaultDeployment()
 
+	d.Spec.Template.Spec.Tolerations = []corev1.Toleration{
+		{
+			Key:      "cloud.hashicorp.com/terraform",
+			Operator: corev1.TolerationOpEqual,
+			Value:    "operator",
+			Effect:   corev1.TaintEffectPreferNoSchedule,
+		},
+	}
+
 	assert.Equal(t, d, deployment)
 }
 
@@ -425,21 +493,33 @@ func TestDeploymentKubeRbacProxySecurityContext(t *testing.T) {
 	assert.Equal(t, d, deployment)
 }
 
-// TODO
 func TestDeploymentKubeRbacProxyResources(t *testing.T) {
 	options := &helm.Options{
-		Version: helmChartVersion,
-		SetValues: map[string]string{
-			"kubeRbacProxy.image.repository": "this",
-			"kubeRbacProxy.image.pullPolicy": string(corev1.PullAlways),
-			"kubeRbacProxy.image.tag":        "0.0.1",
+		SetJsonValues: map[string]string{
+			"kubeRbacProxy.resources.limits": `{
+				"cpu": "2",
+				"memory": "512Mi"
+			}`,
+			"kubeRbacProxy.resources.requests": `{
+				"cpu": "250m",
+				"memory": "128Mi"
+			}`,
 		},
+		Version: helmChartVersion,
 	}
 	deployment := renderDeploymentManifest(t, options)
 	d := defaultDeployment()
 
-	d.Spec.Template.Spec.Containers[1].Image = "this:0.0.1"
-	d.Spec.Template.Spec.Containers[1].ImagePullPolicy = corev1.PullAlways
+	d.Spec.Template.Spec.Containers[1].Resources = corev1.ResourceRequirements{
+		Limits: corev1.ResourceList{
+			corev1.ResourceCPU:    resource.MustParse("2"),
+			corev1.ResourceMemory: resource.MustParse("512Mi"),
+		},
+		Requests: corev1.ResourceList{
+			corev1.ResourceCPU:    resource.MustParse("250m"),
+			corev1.ResourceMemory: resource.MustParse("128Mi"),
+		},
+	}
 
 	assert.Equal(t, d, deployment)
 }

charts/test/unit/helpers.go

@@ -88,9 +88,7 @@ var (
 
 func init() {
 	var err error
-	helmChartVersion, err = getChartVersion()
-	fmt.Println("INIT:", helmChartVersion)
-	if err != nil {
+	if helmChartVersion, err = getChartVersion(); err != nil {
 		log.Fatal(err)
 		os.Exit(1)
 	}