fix: false-positive Stackdriver error in diagnose

`operator diagnose` contains checks to validate your Telemetry configuration. However,
due to a glitch in how the `coalesce` helper handles booleans, it always reports an
error with missing Stackdriver configuration if you omit Stackdriver settings (even if
you specify other telemetry backend values correctly).

This change simply pulls the boolean out of the coalesce call and checks it separately.
An updated unit test is included to validate a dogstatsd-only configuration.

Author: rnubel

command/operator_diagnose.go

@@ -273,7 +273,7 @@ func (c *OperatorDiagnoseCommand) offlineDiagnostics(ctx context.Context) error
 			}
 
 			// If any Stackdriver setting is present but we're missing the basic fields...
-			if coalesce(t.StackdriverNamespace, t.StackdriverLocation, t.StackdriverDebugLogs, t.StackdriverNamespace) != nil {
+			if coalesce(t.StackdriverNamespace, t.StackdriverLocation, t.StackdriverNamespace) != nil || t.StackdriverDebugLogs {
 				if t.StackdriverProjectID == "" {
 					return errors.New("incomplete Stackdriver telemetry configuration, missing stackdriver_project_id")
 				}

command/operator_diagnose_test.go

@@ -627,6 +627,18 @@ func TestOperatorDiagnoseCommand_Run(t *testing.T) {
 				},
 			},
 		},
+		{
+			"diagnose_telemetry_ok_dogstatsd",
+			[]string{
+				"-config", "./server/test-fixtures/diagnose_ok_dogstatsd_telemetry.hcl",
+			},
+			[]*diagnose.Result{
+				{
+					Name:   "Check Telemetry",
+					Status: diagnose.OkStatus,
+				},
+			},
+		},
 		{
 			"diagnose_telemetry_partial_stackdriver",
 			[]string{

command/server/test-fixtures/diagnose_ok_dogstatsd_telemetry.hcl

@@ -0,0 +1,22 @@
+# Copyright IBM Corp. 2016, 2025
+# SPDX-License-Identifier: BUSL-1.1
+
+disable_cache = true
+disable_mlock = true
+ui = true
+
+listener "tcp" {
+	address = "127.0.0.1:8200"
+}
+
+backend "consul" {
+	advertise_addr = "foo"
+	token = "foo"
+}
+
+telemetry {
+	dogstatsd_tags = ["tag1:value"]
+	dogstatsd_addr = "127.0.0.1:8164"
+}
+
+cluster_addr = "127.0.0.1:8201"