fix: one more possible null deref (#1560)

mrkaye97 · web-flow · commit 6c52c63f6310 · 2025-04-15T14:57:30.000-04:00
diff --git a/pkg/repository/postgres/workflow.go b/pkg/repository/postgres/workflow.go
@@ -390,6 +390,12 @@ func (w *workflowAPIRepository) CreateCronWorkflow(ctx context.Context, tenantId
 		}
 	}
 
+	var priority int32 = 1
+
+	if opts.Priority != nil {
+		priority = *opts.Priority
+	}
+
 	createParams := dbsqlc.CreateWorkflowTriggerCronRefForWorkflowParams{
 		Workflowid:         sqlchelpers.UUIDFromStr(opts.WorkflowId),
 		Crontrigger:        opts.Cron,
@@ -400,7 +406,7 @@ func (w *workflowAPIRepository) CreateCronWorkflow(ctx context.Context, tenantId
 			Valid:                         true,
 			WorkflowTriggerCronRefMethods: dbsqlc.WorkflowTriggerCronRefMethodsAPI,
 		},
-		Priority: sqlchelpers.ToInt(*opts.Priority),
+		Priority: sqlchelpers.ToInt(priority),
 	}
 
 	cronTrigger, err := w.queries.CreateWorkflowTriggerCronRefForWorkflow(ctx, w.pool, createParams)

Original file line number	Diff line number	Diff line change
`@@ -390,6 +390,12 @@ func (w *workflowAPIRepository) CreateCronWorkflow(ctx context.Context, tenantId`
`390`	`390`	`}`
`391`	`391`	`}`
`392`	`392`
	`393`	`+ var priority int32 = 1`
	`394`	`+`
	`395`	`+ if opts.Priority != nil {`
	`396`	`+ priority = *opts.Priority`
	`397`	`+ }`
	`398`	`+`
`393`	`399`	`createParams := dbsqlc.CreateWorkflowTriggerCronRefForWorkflowParams{`
`394`	`400`	`Workflowid: sqlchelpers.UUIDFromStr(opts.WorkflowId),`
`395`	`401`	`Crontrigger: opts.Cron,`
`@@ -400,7 +406,7 @@ func (w *workflowAPIRepository) CreateCronWorkflow(ctx context.Context, tenantId`
`400`	`406`	`Valid: true,`
`401`	`407`	`WorkflowTriggerCronRefMethods: dbsqlc.WorkflowTriggerCronRefMethodsAPI,`
`402`	`408`	`},`
`403`		`- Priority: sqlchelpers.ToInt(*opts.Priority),`
	`409`	`+ Priority: sqlchelpers.ToInt(priority),`
`404`	`410`	`}`
`405`	`411`
`406`	`412`	`cronTrigger, err := w.queries.CreateWorkflowTriggerCronRefForWorkflow(ctx, w.pool, createParams)`