Skip to content

Commit 99544bb

Browse files
authored
Fix: read payloads from payload store for event API (#2471)
* fix: read payloads from payload store * debug: add log * debug: more log lines * fix: bug * fix: rm debug lines * fix: comment loc
1 parent b19dc23 commit 99544bb

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

api/v1/server/run/run.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,10 +401,16 @@ func (t *APIServer) registerSpec(g *echo.Group, spec *openapi3.T) (*populator.Po
401401
return nil, "", err
402402
}
403403

404+
payload, err := t.config.V1.OLAP().ReadPayload(timeoutCtx, v1Event.TenantID.String(), v1Event.ExternalID)
405+
406+
if err != nil {
407+
return nil, "", err
408+
}
409+
404410
event = &dbsqlc.Event{
405411
ID: v1Event.ExternalID,
406412
TenantId: v1Event.TenantID,
407-
Data: v1Event.Payload,
413+
Data: payload,
408414
CreatedAt: pgtype.Timestamp(v1Event.SeenAt),
409415
AdditionalMetadata: v1Event.AdditionalMetadata,
410416
Key: v1Event.Key,

pkg/repository/v1/olap.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1976,9 +1976,14 @@ func (r *OLAPRepositoryImpl) BulkCreateEventsAndTriggers(ctx context.Context, ev
19761976

19771977
defer rollback()
19781978

1979-
// todo: remove this when we remove dual writes
19801979
eventsToInsert := events
1980+
eventExternalIdToPayload := make(map[pgtype.UUID][]byte)
1981+
1982+
for i, payload := range eventsToInsert.Payloads {
1983+
eventExternalIdToPayload[eventsToInsert.Externalids[i]] = payload
1984+
}
19811985

1986+
// todo: remove this when we remove dual writes
19821987
if !r.payloadStore.OLAPDualWritesEnabled() {
19831988
payloads := make([][]byte, len(eventsToInsert.Payloads))
19841989

@@ -2066,14 +2071,15 @@ func (r *OLAPRepositoryImpl) BulkCreateEventsAndTriggers(ctx context.Context, ev
20662071
ID: id,
20672072
InsertedAt: insertedAt,
20682073
}] = event.ExternalID
2074+
payload := eventExternalIdToPayload[event.ExternalID]
20692075

20702076
offloadToExternalOpts = append(offloadToExternalOpts, OffloadToExternalStoreOpts{
20712077
StorePayloadOpts: &StorePayloadOpts{
20722078
Id: event.ID,
20732079
InsertedAt: event.SeenAt,
20742080
ExternalId: event.ExternalID,
20752081
Type: sqlcv1.V1PayloadTypeTASKINPUT,
2076-
Payload: event.Payload,
2082+
Payload: payload,
20772083
TenantId: event.TenantID.String(),
20782084
},
20792085
OffloadAt: time.Now(),

0 commit comments

Comments
 (0)