[BUG] Cannot pass LogExtra to Logger in Typescript

[JJCLane]

Describe the issue
When attempting to log using the ctx.logger and passing a value into the extra argument, it fails to log the value and shows this warning in the worker:

ctx.logger.error(`Failure response`, { extra: 'test' });
[WARN/Dispatcher] Could not put log: /EventsService/PutLog INVALID_ARGUMENT: Invalid metadata JSON: json: cannot unmarshal string into Go value of type map[string]interface {} undefined

Based on the warning I attempted to pass in an object instead, which removed the warning but still logs undefined.

ctx.logger.error(`Failure response`, { extra: {'test': 'test' } });
[ERROR/ctx] Failure response undefined

Environment

• SDK: TypeScript v1.10.3
• Engine: Self-hosted ghcr.io/hatchet-dev/hatchet/hatchet-lite:latest

Expected behavior
The extra data passed would be logged and visible in the dashboard.

[aashmanVerma]

@JJCLane I went into it, here is what I found.

File: sdks/typescript/src/v1/client/worker/context.ts
The error method don't wrap the metadata object, but the internal log() method expects it to be wrapped.

Lines 295-297 - The error method:

error: (message: string, extra?: LogExtra) => {
  return this.log(message, 'ERROR', extra);
},

Lines 246-261 - The log method that receives it:

log(message: string, level?: LogLevel, extra?: LogExtra) {
  const { stepRunId } = this.action;
  if (!stepRunId) {
    this._logger.warn('cannot log from context without stepRunId');
    return Promise.resolve();
  }
  const logger = this.v1.config.logger('ctx', this.v1.config.log_level);
  const contextExtra = {
    workflowRunId: this.action.workflowRunId,
    taskRunId: this.action.stepRunId,
    retryCount: this.action.retryCount,
    workflowName: this.action.jobName,
    ...extra?.extra,  // ← Expects extra to be wrapped: { extra: { your: 'data' } }
  };
  
  // ... rest of method
}

[JJCLane]

@JJCLane I went into it, here is what I found.

File: sdks/typescript/src/v1/client/worker/context.ts The error method don't wrap the metadata object, but the internal log() method expects it to be wrapped.

@aashmanVerma Thank you, isn’t that what I tried in the second example? It fixes the warning but still doesn’t log anything.

[aashmanVerma]

@JJCLane that's from line 272-274:

} else if (level === 'ERROR') {
  promises.push(logger.error(message, extra?.error, contextExtra));
}

It's logging extra?.error which is undefined (you only have extra.extra).
Did u get it?

[JJCLane]

@aashmanVerma ah ok, because of the types it only accepts an Error object for that property. I will see if I can get it working.