Skip to content

Commit 9ac017d

Browse files
committed
fix(pattern-iterator): initialize user reading process in UserFileBatchRead and make batchUserList final in UserFileBatch
1 parent 1009c8d commit 9ac017d

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

pattern-design/pattern-iterator/src/main/java/com/helltractor/demo/user/UserFileBatch.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ private class UserFileBatchIterator implements Iterator<List<User>> {
3131

3232
private boolean finished = false;
3333
private final BufferedReader reader;
34-
private List<User> batchUserList = new ArrayList<>();
34+
private final List<User> batchUserList = new ArrayList<>();
3535

3636
UserFileBatchIterator() {
3737
try {

pattern-design/pattern-iterator/src/main/java/com/helltractor/demo/user/UserFileBatchRead.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ private class UserFileReadBatchIterator implements Iterator<User> {
3737
UserFileReadBatchIterator() {
3838
try {
3939
this.reader = new BufferedReader(new FileReader(file));
40+
readUsersFromFile();
4041
} catch (FileNotFoundException e) {
4142
throw new RuntimeException("File not found: " + file.getAbsolutePath(), e);
4243
}
@@ -73,7 +74,7 @@ private void readUsersFromFile() {
7374

7475
@Override
7576
public boolean hasNext() {
76-
if (batchUserList == null || index >= batchUserList.size() && !finished) {
77+
if (index >= batchUserList.size() && !finished) {
7778
try {
7879
readUsersFromFile();
7980
} catch (Exception e) {

0 commit comments

Comments
 (0)