Improve: Better the Win32 api

Author: hiddenblue

Avalonia.CpuLimiter/Models/AdminRunner.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
+using System.Runtime.InteropServices;
 using System.Security.Principal;
 using System.Text;
 using System.Threading.Tasks;
@@ -12,10 +13,17 @@ public class AdminRunner
     {
         public static bool IsRunAsAdmin()
         {
-            WindowsIdentity identity = WindowsIdentity.GetCurrent();
-            WindowsPrincipal principal = new(identity);
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+            {
+                WindowsIdentity identity = WindowsIdentity.GetCurrent();
+                WindowsPrincipal principal = new(identity);
 
-            return principal.IsInRole(WindowsBuiltInRole.Administrator);
+                return principal.IsInRole(WindowsBuiltInRole.Administrator); 
+            }
+            else
+            {
+                throw new PlatformNotSupportedException();
+            }
         }
 
         public static void RunElevated()
@@ -38,15 +46,20 @@ public static void RunElevated()
             }
         }
 
-        public static void RunAsAdmin(int CPUCoreNum, string Path)
+        public static void RunAsAdmin(int cpuCoreNum, string path)
         {
 
-            if (string.IsNullOrWhiteSpace(Path))
+            if (string.IsNullOrWhiteSpace(path))
                 throw new InvalidOperationException("The executable file Path cannot be empty");
 
-            Console.WriteLine("Running as adminisitrator.");
+            if(IsRunAsAdmin())
+                Console.WriteLine("Running as adminisitrator.");
+            else
+            {
+                Console.WriteLine($"Running without administrator privileges.");
+            }
 
-            ProcessStartInfo startInfo = new ProcessStartInfo(Path)
+            ProcessStartInfo startInfo = new ProcessStartInfo(path)
             {
                 UseShellExecute = false,
                 RedirectStandardInput = true,
@@ -62,28 +75,18 @@ public static void RunAsAdmin(int CPUCoreNum, string Path)
 
 
             process.Start();
-            Win32CpuAffinity win32CpuAffinity = new(CPUCoreNum);
+            Win32CpuAffinity win32CpuAffinity = new(cpuCoreNum);
 
-            process = win32CpuAffinity.SetProcessWithLimitedCPU(process);
+            process = win32CpuAffinity.SetProcessWithLimitedCpu(process);
 
-            if (process != null)
-            {
-                Console.WriteLine($"Process started with PID: {process.Id}");
-
-                process.WaitForExit();
-
-                int exitCode = process.ExitCode;
-                Console.WriteLine($"Process exited with exit code: {exitCode}");
-
-                process.Close();
+            Console.WriteLine($"Process started with PID: {process.Id}");
 
-            }
-            else
-            {
-                Console.WriteLine("Failed to start process.");
+            process.WaitForExit();
 
-            }
+            int exitCode = process.ExitCode;
+            Console.WriteLine($"Process exited with exit code: {exitCode}");
 
+            process.Close();
         }
     }
 }

Avalonia.CpuLimiter/Models/NativeCPUAffinity.cs

@@ -4,10 +4,11 @@
 using System.Text;
 using System.Threading.Tasks;
 using System.Diagnostics;
+using System.Runtime.InteropServices;
 
 namespace Avalonia.CpuLimiter.Models
 {
-    class NativeCPUAffinity
+    class NativeCpuAffinity
     {
         // 写一个利用c#原生 api 限制当前程序调用CPU核心的类
 
@@ -17,7 +18,12 @@ public static void SetProcessAffinity(int processId, int cpuId)
             Process process = System.Diagnostics.Process.GetCurrentProcess();
 
             // 设置进程的CPU亲和性
-            process.ProcessorAffinity = 1 << cpuId;
+            if(RuntimeInformation.IsOSPlatform(OSPlatform.Windows) || RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
+                process.ProcessorAffinity = 1 << cpuId;
+            else
+            {
+                throw new PlatformNotSupportedException("not supported on this platform");
+            }
 
         }
 
@@ -26,7 +32,13 @@ public static void SetProcessAffinity(int cpuId)
             // 获取当前进程
             Process process = System.Diagnostics.Process.GetCurrentProcess();
             // 设置进程的CPU亲和性
-            process.ProcessorAffinity = 1 << cpuId;
+            
+            if(RuntimeInformation.IsOSPlatform(OSPlatform.Windows) || RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
+                process.ProcessorAffinity = 1 << cpuId;
+            else
+            {
+                throw new PlatformNotSupportedException("not supported on this platform");
+            }
 
         }
 
@@ -36,7 +48,13 @@ public static int GetProcessAffinity(int processId)
             System.Diagnostics.Process process = System.Diagnostics.Process.GetCurrentProcess();
 
             // 获取进程的CPU亲和性
-            return process.ProcessorAffinity.ToInt32();
+            if(RuntimeInformation.IsOSPlatform(OSPlatform.Windows) || RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
+                return process.ProcessorAffinity.ToInt32();
+            else
+            {
+                throw new PlatformNotSupportedException("not supported on this platform");
+            }
+            
         }
 
 

Avalonia.CpuLimiter/Models/Win32CpuAffinity.cs

@@ -8,9 +8,9 @@ namespace Avalonia.CpuLimiter.Models;
 
 class Win32CpuAffinity
 {
-    public Win32CpuAffinity(int CPULogicalCoreNum)
+    public Win32CpuAffinity(int cpuLogicalCoreNum)
     {
-        CpuLogicalCoreNum = CPULogicalCoreNum;
+        CpuLogicalCoreNum = cpuLogicalCoreNum;
     }
 
     [DllImport("kernel32.dll", SetLastError = true)]
@@ -19,7 +19,7 @@ public Win32CpuAffinity(int CPULogicalCoreNum)
     [DllImport("kernel32.dll", SetLastError = true)]
     public static extern bool GetProcessAffinityMask(nint hProcess, nint dwProcessAffinityMask, nint lpSystemAffinityMask);
 
-    public Process SetProcessWithLimitedCPU(Process process)
+    public Process SetProcessWithLimitedCpu(Process process)
     {
         if (CpuLogicalCoreNum <= 0)
         {

Avalonia.CpuLimiter/Services/FilesService.cs

@@ -24,7 +24,7 @@ public FilesService(Window target)
         {
             var files = await _target.StorageProvider.OpenFilePickerAsync(new FilePickerOpenOptions()
             {
-                Title = "Open Text File",
+                Title = "Select executable file",
                 AllowMultiple = false