Skip to content

Commit 9fd5088

Browse files
authored
Unpin nbconvert (#155)
Can no longer reproduce the error in #84.
1 parent 451bde0 commit 9fd5088

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

setup.py

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,22 @@ def get_setup_version(root, reponame):
5959
'jupyter_client',
6060
'ipykernel',
6161
'nbformat',
62-
'nbconvert <5.4', # see https://github.com/pyviz/nbsite/issues/84
62+
'nbconvert',
6363
'notebook',
6464
'sphinx',
6565
'beautifulsoup4',
66+
# Without the tornado pin below, I get:
67+
# File "[...]/code/[...]/nbsite/nbsite/nbbuild.py", line 35, in <module>
68+
# from nbconvert import NotebookExporter, PythonExporter, HTMLExporter
69+
# File "[...]/[...]/lib/python3.7/site-packages/nbconvert/__init__.py", line 7, in <module>
70+
# from . import postprocessors
71+
# File "[...]/[...]/lib/python3.7/site-packages/nbconvert/postprocessors/__init__.py", line 5, in <module>
72+
# from .serve import ServePostProcessor
73+
# File "[...]/[...]/lib/python3.7/site-packages/nbconvert/postprocessors/serve.py", line 19, in <module>
74+
# class ProxyHandler(web.RequestHandler):
75+
# File "[...]/[...]/lib/python3.7/site-packages/nbconvert/postprocessors/serve.py", line 21, in ProxyHandler
76+
# @web.asynchronous
77+
#AttributeError: module 'tornado.web' has no attribute 'asynchronous'
6678
'tornado <6'
6779
],
6880
extras_require= {

0 commit comments

Comments
 (0)