Skip to content

Signal when a kernel build comes from an uncommitted (dirty) kernel-builder version #648

Description

@moon-bot-app

Context

We want to make it clear to users when a build comes from a kernel-builder version that contains uncommitted changes, to improve reproducibility guarantees.

Proposal

Add the git commit SHA to the build metadata, along with a dirty bool. If dirty is set, we know that the kernel was built with uncommitted sources.

Suggested behavior when dirty is true:

  1. At load time — Show warnings to the user when they're trying to load the kernel.
  2. At upload time — Throw warnings when the builds are going to get uploaded to the Hub.
  3. On the Hub repo — Show warnings on the corresponding Hub repo page.

References

From discussion by @sayakpaul and @danieldk.


Created via Moon Bot for Sayak Paul (Slack U03AU4E7DJB) — Slack thread

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions