Follow-up: deferred review findings from PR #902

[philcunliffe]

Deferred, non-blocking findings from the review rounds on PR #902 (head a7e8a1d). All three review findings from the final round were verified fixed at that head (npm test 4489 pass / 0 fail, typecheck clean, re-verified independently at triage). What remains is deferred by design or is polish, not a merge blocker.

1. hyp init --force re-init drops proxy_mode from a still-proxying pre-0262 machine (accepted-by-design in review round 1, flagged for follow-up)

With the claude picker row no longer declaring compose.gateway_proxy_mode, a non-interactive hyp init --force on a pre-LLP-0262 install whose ~/.claude/settings.json still carries a repointed base URL composes a gateway without proxy_mode. prepareInterception then takes the tunnelOnly branch and capture drops to zero rows, observable only via the aigw.proxy_mode_stale_ca daemon-log line.

• The carry-forward protection rides args.existing, supplied only by the interactive reconfigure lane: src/core/cli/wizard/pick.js:387 passes it, src/core/cli/walkthrough.js:685 does not, and the fold documents this as deliberate at src/core/cli/walkthrough.js:963-968 ("a non-interactive --force re-init composes from scratch by design, the whole-file overwrite is its own consent", LLP 0243/0244).
• Deferred because enforcing the old behaviour would revert the change PR Stop offering a proxy migration and a CA repair the otel Claude attach cannot perform #902 exists to make, and the corpus settled the row change (LLP 0243 Extended-by: LLP 0262). The follow-up worth considering: have the 0262 migration guarantee a re-attach runs alongside a forced re-init, so the legacy population cannot land in silent tunnelOnly capture.

2. PR body inaccuracy: "--json keys are unchanged"

proxy_trust.proxy_mode_configured is a new (additive, tri-state) key in hyp status --json (src/core/commands/status.js:319-326). Harmless, but correct the wording if the PR body is reused for release notes.

3. README "Proxy mode" section still carries the stale password-dialog claim

Review round 1 fixed the contradictory claim in docs/PRIVACY.md and src/core/cli/core_commands.js ("a later re-attach does not ask for your password again"), but noted the README "Proxy mode" section still carries it and was outside the PR's diff. Bring it in line with the LLP 0262 otel-attach reality.

Backlink: PR #902.

[philcunliffe]

PR #933 (draft) covers finding 3 only, and closes with Fixes #923. Recording why the other two are not in it, so the close is not read as covering them.

Finding 3 (README "Proxy mode") is a real defect on master: LLP 0262 removed the last production caller of installCaTrust (it is now named nowhere outside src/core/tls/darwin_trust.js), but the README still described attach adding the CA to the login keychain, macOS raising a password dialog, and a detach keeping the trust "so re-attaching does not ask again". That last claim frames a leftover user-domain trusted root as a convenience being held for the reader. Fixed, with test/core/readme-proxy-trust-claims.test.js as the gate. docs/PRIVACY.md and the hyp detach help text are left to PR #902, so the diffs do not overlap.

Finding 1 (hyp init --force drops proxy_mode) cannot be reproduced on master: it needs the claude picker row to have stopped declaring compose.gateway_proxy_mode, which is PR #902's change and is still unmerged (hypaware-core/plugins-workspace/claude/hypaware.plugin.json:58 still declares it). The behaviour is also documented as deliberate at src/core/cli/walkthrough.js:963-968 under LLP 0243/0244, both Accepted. The suggested follow-up, having the 0262 migration guarantee a re-attach alongside a forced re-init, is a change to an accepted decision: it wants a request LLP after PR #902 lands, not a patch now. Worth re-opening as its own issue at that point.

Finding 2 is a PR-body inaccuracy on #902, not a repo artifact.

[philcunliffe]

All three follow-ups are now accounted for:\n\n1. The forced-setup legacy proxy migration is preserved as the new design request #960.\n2. The merged #902 description now accurately records the additive tri-state proxy_trust.proxy_mode_configured JSON field.\n3. The README/privacy/help correction and its regression gate were consolidated from #933 into #902 before #902 merged.\n\nClosing this roll-up issue.