Follow-up: deferred review findings from PR #929

[philcunliffe]

Follow-up from the neutral triage of PR #933 (head 8f4712d2397c27b39a2acfc1e1bdc23ce7fcbf62, branch fix/issue-923). Every finding from the two review rounds on that PR was verified fixed in the head commit except the one below, which is non-blocking and deferred here so the PR can merge.

1. test/core/llp-ref-hygiene.test.js dies on a mid-rename working tree (severity: low, test robustness)

Noted in review round 2 on PR #933 under "Verified, no action". trackedFiles() (test/core/llp-ref-hygiene.test.js:303) feeds git ls-files -z output straight into fs.readFileSync at test/core/llp-ref-hygiene.test.js:336 with no fs.existsSync filter. A path that is tracked but absent from the working tree (mid-rebase, mid-rename) makes the whole test file throw ENOENT at module load instead of reporting a hygiene result.

The sibling gate landed by PR #933 already carries the pattern to copy: trustInstallerNamers() in test/core/proxy-trust-claims.test.js filters git ls-files output with fs.existsSync(path.join(REPO_ROOT, file)) before reading, with a comment explaining why ("A tracked path can be absent from the working tree mid-rebase. That is not a caller, and this gate must not die on it.").

Fix: apply the same existsSync filter to trackedFiles() in test/core/llp-ref-hygiene.test.js.

Not a production defect: the gap only bites a developer running npm test on a transiently inconsistent working tree, and the failure is loud, not silent.

---

Backlink: PR #933 (triage record 8f4712d2397c27b39a2acfc1e1bdc23ce7fcbf62).

[philcunliffe]

What neutral was doing

Backlog staleness audit. After two consecutive issue-fix dispatches (#758, #834) turned
out to be already fixed on master but never closed, neutral audited all 39 open
non-stuck neutral:fix issues against origin/master (a4c6350b) before spending
more admission slots. This issue is in the already-fixed bucket, so there is no
failing reproduction and therefore no PR (LLP 0002).

Evidence

Fixed by ff895aa4 (PR #947), a verified ancestor of origin/master. trackedFiles was
hoisted to test/helpers/tracked_files.js with the fs.existsSync filter, and is
consumed at test/core/llp-ref-hygiene.test.js:16.

Why this keeps happening

The fixing commits for #878, #843, #756 and #726 all name their issue in the commit
body ((#878), (#726)) with no Fixes trailer, so GitHub never auto-closed
them. That is the same prose-reference pattern that left #758 and #834 open. A CI check
on merged PR bodies would stop this recurring, and would be cheaper than repeating this
audit.

What it needs from you

Neutral never closes an issue - GitHub does that on merge of a Fixes #N PR, and there
is no fix to merge. A human needs to close this one.

Closable batch from the same audit: #836 #878 #819 #842 #940 #971 #979 #756 #726.

How to unstick

Reply with a comment on this issue; neutral monitors this thread and will re-engage with
your guidance on its next tick.