feat: group tasks by connection (#1071)

Group the alert tasks fetched from mongo into groups based on what needs to run from the same connection. This sets up for further optimizations and connection reuse.

Author: dhable

.changeset/ninety-books-hear.md

@@ -0,0 +1,5 @@
+---
+"@hyperdx/api": patch
+---
+
+Changes the order of alert evaluation to group queries by the connection on the alert.

packages/api/src/controllers/connection.ts

@@ -18,15 +18,15 @@ export function getConnectionById(
 
 export function createConnection(
   team: string,
-  connection: Omit<IConnection, '_id'>,
+  connection: Omit<IConnection, 'id' | '_id'>,
 ) {
   return Connection.create({ ...connection, team });
 }
 
 export function updateConnection(
   team: string,
   connectionId: string,
-  connection: Omit<IConnection, '_id'>,
+  connection: Omit<IConnection, 'id' | '_id'>,
 ) {
   return Connection.findOneAndUpdate({ _id: connectionId, team }, connection, {
     new: true,

packages/api/src/controllers/savedSearch.ts

@@ -21,8 +21,7 @@ export async function getSavedSearches(teamId: string) {
   return savedSearches.map(savedSearch => ({
     ...savedSearch.toJSON(),
     alerts: alertsBySavedSearchId[savedSearch._id.toString()]?.map(alert => {
-      const { _id, ...restAlert } = alert.toJSON();
-      return { id: _id, ...restAlert };
+      return alert.toJSON();
     }),
   }));
 }

packages/api/src/models/alert.ts

@@ -41,7 +41,7 @@ export enum AlertSource {
 }
 
 export interface IAlert {
-  _id: ObjectId;
+  id: string;
   channel: AlertChannel;
   interval: AlertInterval;
   source?: AlertSource;
@@ -162,6 +162,7 @@ const AlertSchema = new Schema<IAlert>(
   },
   {
     timestamps: true,
+    toJSON: { virtuals: true },
   },
 );
 

packages/api/src/models/connection.ts

@@ -5,6 +5,7 @@ type ObjectId = mongoose.Types.ObjectId;
 
 export interface IConnection {
   _id: ObjectId;
+  id: string;
   host: string;
   name: string;
   password: string;