Added README and fixed gas values inconsistencies

Author: Tomas-Silva2187

packages/cactus-plugin-satp-hermes/README.md

@@ -137,6 +137,10 @@ const gatewayConfig: {
   gid: {
     id: "gatewayId",
     name: "GatewayWithBesuConnection",
+    identificationCredential: {
+      signingAlgorithm: "SECP256K1", // the cryptographic algorithm used to generate the gateway's key pair
+      pubKey: "0x03a34e1d66b78e47fa1bba3445a6019acb5b9c87d0c6ad81c09e7d496682ae81fc", // the public key of the gateway
+    }
     version: [
       {
         "Core": "v02",
@@ -279,11 +283,13 @@ const leafConfig = {
     ledgerType: "BESU_2X"                     // Ledger type constant for Besu 2.x
   },
   signingCredential: {
-    ethAccount: "0x736dC9B8258Ec5ab2419DDdffA9e1fa5C201D0b4",           // Ethereum account address
+    bridgeOwnerAddress: "0x736dC9B8258Ec5ab2419DDdffA9e1fa5C201D0b4",           // Ethereum account address of the owner of the bridge
     secret: "0xc31e76f70d6416337d3a7b7a8711a43e30a14963b5ba622fa6c9dbb5b4555986", // Private key in hex
     type: "PRIVATE_KEY_HEX"
   },
-  gas: 999999999999999,                       // Default gas limit for transactions
+  gasConfig: {
+    gasLimit: 999999999999999,  // Default gas limit for transactions
+  },
   connectorOptions: {
     rpcApiHttpHost: "http://172.20.0.6:8545", // Besu JSON-RPC HTTP endpoint
     rpcApiWsHost: "ws://172.20.0.6:8546"      // Besu JSON-RPC WebSocket endpoint
@@ -301,11 +307,15 @@ const leafConfig = {
     ledgerType: "ETHEREUM"                    // Ledger type constant for Ethereum
   },
   signingCredential: {
-    ethAccount: "0x09D16c22216BC873e53c8D93A38420f48A81dF1B", // Ethereum account address
+    bridgeOwnerAddress: "0x09D16c22216BC873e53c8D93A38420f48A81dF1B", // Ethereum account address
     secret: "test",                                // Key store password or secret
     type: "GETH_KEYCHAIN_PASSWORD"                 // Credential type for geth keychain
   },
-  gas: 5000000,                                   // Default gas limit for transactions
+  gasConfig: {
+    gas: "6721975", // Default gas limit for transactions
+    gasPrice: "20000000000" // Default gas Price
+  }
+                                    
   connectorOptions: {
     rpcApiHttpHost: "http://172.20.0.7:8545",     // Ethereum JSON-RPC HTTP endpoint
     rpcApiWsHost: "ws://172.20.0.7:8546"          // Ethereum JSON-RPC WebSocket endpoint
@@ -322,6 +332,10 @@ const gatewayConfig = {
   gid: {
     id: "gatewayId",
     name: "GatewayWithBesuConnection",
+    identificationCredential: {
+      signingAlgorithm: "SECP256K1",
+      pubKey: "0x03a34e1d66b78e47fa1bba3445a6019acb5b9c87d0c6ad81c09e7d496682ae81fc",
+    }
     version: [{ Core: "v02", Architecture: "v02", Crash: "v02" }],
     proofID: "mockProofID10",
     address: "http://gateway1.satp-hermes",
@@ -341,11 +355,13 @@ const gatewayConfig = {
           ledgerType: "BESU_2X",
         },
         signingCredential: {
-          ethAccount: "0x736dC9B8258Ec5ab2419DDdffA9e1fa5C201D0b4",
+          bridgeOwnerAddress: "0x736dC9B8258Ec5ab2419DDdffA9e1fa5C201D0b4",
           secret: "0xc31e76f70d6416337d3a7b7a8711a43e30a14963b5ba622fa6c9dbb5b4555986",
           type: "PRIVATE_KEY_HEX",
         },
-        gas: 999999999999999,
+        gasConfig: {
+          gasLimit: 999999999999999,
+        },        
         connectorOptions: {
           rpcApiHttpHost: "http://172.20.0.6:8545",
           rpcApiWsHost: "ws://172.20.0.6:8546",

packages/cactus-plugin-satp-hermes/src/main/typescript/services/validation/config-validating-functions/bridges-config-validating-functions/validate-besu-config.ts

@@ -111,8 +111,9 @@ function isGasConfig(obj: unknown): obj is BesuGasConfig {
     ) {
       return false;
     }
+    return true;
   }
-  return true;
+  return false;
 }
 
 export function isBesuNetworkId(obj: NetworkId) {

packages/cactus-plugin-satp-hermes/src/test/typescript/environments/besu-test-environment.ts

@@ -98,7 +98,7 @@ export class BesuTestEnvironment {
   public besuConfig!: IBesuNetworkConfig;
 
   public gasConfig: BesuGasConfig = {
-    gasLimit: "999999999",
+    gasLimit: "999999999999999",
   };
 
   private dockerContainerIP?: string;

packages/cactus-plugin-satp-hermes/src/test/typescript/unit/config-validating-functions/validate-cc-config.test.ts

@@ -225,8 +225,7 @@ const besuConfig = {
   wrapperContractAddress: "0x09D16c22216BC873e53c8D93A38420f48A81dF1B",
   wrapperContractName: "exampleWrapperContractName",
   gasConfig: {
-    gas: "999999999999999",
-    gasPrice: "20000000000",
+    gasLimit: "999999999999999",
   },
 } as Partial<IBesuNetworkConfig> & INetworkOptions;
 
@@ -705,7 +704,6 @@ describe("Validate CC Config", () => {
       wrapperContractName: true, //should be a string
       gasConfig: {
         gasLimit: "999999999999999",
-        gasPrice: "20000000000",
       },
     };
     const bridgeConfig = [badBesuConfig];
@@ -751,7 +749,6 @@ describe("Validate CC Config", () => {
       wrapperContractName: "exampleWrapperContractName",
       gasConfig: {
         gasLimit: "999999999999999",
-        gasPrice: "20000000000",
       },
     };
     const bridgeConfig = [badBesuConfig];