Open
Labels
lifecycle/needs-reviewThe issue has not yet been reviewed.The issue has not yet been reviewed.
Description
Two hyperlight-host cargo features add cost without adding value.
print_debugmakes the exporteddebug!macro print to stdout in debug builds, in addition totracing::debug!. Its cfg is evaluated in the caller's crate, so the print never works for external users. Hyperlight itself uses the macro in two places, wheretracing::debug!gives the same output.build-metadatais on by default. It usesbuiltwithgit2to log build details on the first sandbox creation. Its git fields are empty for crates.io users.git2compiles libgit2 from C in every default build, on the critical path to the host build script.
Proposal: remove both features and the debug! macro. Applications that want build details can log them with their own tooling.
Metadata
Metadata
Assignees
Labels
lifecycle/needs-reviewThe issue has not yet been reviewed.The issue has not yet been reviewed.
Activity