support to enable/disable a notif rule (#281)

* ENG-58592 - support to enable/disable a notif rule

* addressed comments

* Update gradle locks

* Revert "Update gradle locks"

This reverts commit 5dff600.

* addressed comments

* addressed comment

* addressed comment & fixed test

---------

Co-authored-by: Kshitiz Saxena <[email protected]>

Author: sidharth-jain23

notification-rule-config-service-api/src/main/proto/org/hypertrace/notification/config/service/v1/notification_rule.proto

@@ -20,6 +20,7 @@ message NotificationRuleMutableData {
   string rate_limit_interval_duration = 6;
 
   NotificationIntegrationTarget integration_target = 7;
+  bool disabled = 8;
 }
 
 message NotificationIntegrationTarget {

notification-rule-config-service-api/src/main/proto/org/hypertrace/notification/config/service/v1/notification_rule_config_service.proto

@@ -37,6 +37,7 @@ message GetAllNotificationRulesRequest {
 
 message NotificationRuleFilter {
   repeated string event_condition_type = 1;
+  optional bool enabled = 2;
 }
 
 message GetAllNotificationRulesResponse {

notification-rule-config-service-impl/src/main/java/org/hypertrace/notification/config/service/NotificationRuleFilteredStore.java

@@ -59,14 +59,21 @@ protected String getContextFromData(NotificationRule object) {
   protected Optional<NotificationRule> filterConfigData(
       NotificationRule data, NotificationRuleFilter filter) {
     return Optional.of(data)
-        .filter(
-            notificationRule ->
-                filter.getEventConditionTypeList().isEmpty()
-                    || filter
-                        .getEventConditionTypeList()
-                        .contains(
-                            notificationRule
-                                .getNotificationRuleMutableData()
-                                .getEventConditionType()));
+        .filter(rule -> satisfiesEnabledPredicate(rule, filter))
+        .filter(rule -> satisfiesConditionTypePredicate(rule, filter));
+  }
+
+  private boolean satisfiesEnabledPredicate(
+      NotificationRule notificationRule, NotificationRuleFilter filter) {
+    return !filter.hasEnabled()
+        || filter.getEnabled() != notificationRule.getNotificationRuleMutableData().getDisabled();
+  }
+
+  private boolean satisfiesConditionTypePredicate(
+      NotificationRule notificationRule, NotificationRuleFilter filter) {
+    return filter.getEventConditionTypeList().isEmpty()
+        || filter
+            .getEventConditionTypeList()
+            .contains(notificationRule.getNotificationRuleMutableData().getEventConditionType());
   }
 }

notification-rule-config-service-impl/src/test/java/org/hypertrace/notification/config/service/NotificationRuleConfigServiceImplTest.java

@@ -46,9 +46,11 @@ void beforeEach() {
   @Test
   void createReadUpdateDeleteNotificationRules() {
     NotificationRuleMutableData notificationRuleMutableData1 =
-        getNotificationRuleMutableData("rule1", "channel1");
+        getNotificationRuleMutableData("rule1", "channel1", false);
     NotificationRuleMutableData notificationRuleMutableData2 =
-        getNotificationRuleMutableData("rule2", "channel1");
+        getNotificationRuleMutableData("rule2", "channel1", false);
+    NotificationRuleMutableData notificationRuleMutableData3 =
+        getNotificationRuleMutableData("rule3", "channel1", false);
     when(notificationRuleStore.getAllObjects(any())).thenReturn(List.of());
 
     NotificationRule notificationRule1 =
@@ -86,8 +88,25 @@ void createReadUpdateDeleteNotificationRules() {
                     .build())
             .getNotificationRule());
 
+    NotificationRule notificationRule3 =
+        notificationStub
+            .createNotificationRule(
+                CreateNotificationRuleRequest.newBuilder()
+                    .setNotificationRuleMutableData(notificationRuleMutableData3)
+                    .build())
+            .getNotificationRule();
+
     assertEquals(
-        List.of(notificationRule2, notificationRule1),
+        notificationRule3,
+        notificationStub
+            .getNotificationRule(
+                GetNotificationRuleRequest.newBuilder()
+                    .setNotificationRuleId(notificationRule3.getId())
+                    .build())
+            .getNotificationRule());
+
+    assertEquals(
+        List.of(notificationRule3, notificationRule2, notificationRule1),
         notificationStub
             .getAllNotificationRules(
                 GetAllNotificationRulesRequest.newBuilder()
@@ -114,7 +133,35 @@ void createReadUpdateDeleteNotificationRules() {
                     .build())
             .getNotificationRule();
     assertEquals(ruleToUpdate, updatedRule);
+    // disable rule
+    NotificationRule ruleToUpdate3 =
+        notificationRule3.toBuilder()
+            .setNotificationRuleMutableData(
+                notificationRule3.getNotificationRuleMutableData().toBuilder()
+                    .setDisabled(true)
+                    .build())
+            .build();
+    NotificationRule updatedRule3 =
+        notificationStub
+            .updateNotificationRule(
+                UpdateNotificationRuleRequest.newBuilder()
+                    .setNotificationRuleMutableData(ruleToUpdate3.getNotificationRuleMutableData())
+                    .setId(ruleToUpdate3.getId())
+                    .build())
+            .getNotificationRule();
+    assertEquals(ruleToUpdate3, updatedRule3);
 
+    assertEquals(
+        List.of(updatedRule3, notificationRule2, updatedRule),
+        notificationStub
+            .getAllNotificationRules(
+                GetAllNotificationRulesRequest.newBuilder()
+                    .setFilter(
+                        NotificationRuleFilter.newBuilder()
+                            .addEventConditionType("metricAnomalyEventCondition")
+                            .build())
+                    .build())
+            .getNotificationRulesList());
     assertEquals(
         List.of(notificationRule2, updatedRule),
         notificationStub
@@ -123,6 +170,7 @@ void createReadUpdateDeleteNotificationRules() {
                     .setFilter(
                         NotificationRuleFilter.newBuilder()
                             .addEventConditionType("metricAnomalyEventCondition")
+                            .setEnabled(true)
                             .build())
                     .build())
             .getNotificationRulesList());
@@ -131,6 +179,18 @@ void createReadUpdateDeleteNotificationRules() {
         DeleteNotificationRuleRequest.newBuilder()
             .setNotificationRuleId(notificationRule2.getId())
             .build());
+    assertEquals(
+        List.of(updatedRule3, updatedRule),
+        notificationStub
+            .getAllNotificationRules(
+                GetAllNotificationRulesRequest.newBuilder()
+                    .setFilter(
+                        NotificationRuleFilter.newBuilder()
+                            .addEventConditionType("metricAnomalyEventCondition")
+                            .build())
+                    .build())
+            .getNotificationRulesList());
+
     assertEquals(
         List.of(updatedRule),
         notificationStub
@@ -139,19 +199,21 @@ void createReadUpdateDeleteNotificationRules() {
                     .setFilter(
                         NotificationRuleFilter.newBuilder()
                             .addEventConditionType("metricAnomalyEventCondition")
+                            .setEnabled(true)
                             .build())
                     .build())
             .getNotificationRulesList());
   }
 
   private NotificationRuleMutableData getNotificationRuleMutableData(
-      String name, String channelId) {
+      String name, String channelId, boolean disabled) {
     return NotificationRuleMutableData.newBuilder()
         .setRuleName(name)
         .setDescription("sample rule")
         .setChannelId(channelId)
         .setEventConditionType("metricAnomalyEventCondition")
         .setEventConditionId("rule-1")
+        .setDisabled(disabled)
         .build();
   }