Replace critical-notice() SASS mixin with equivalent class
#8958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
michaelchadwick
changed the title
critical-choice() SASS mixin with equivalent classcritical-notice() SASS mixin with equivalent class
michaelchadwick
force-pushed
the
6663-replace-critical-notice-sass-mixin
branch
from
06e93a3 to
3425d74
Compare
stopfstedt
reviewed
Nov 19, 2025
packages/ilios-common/app/styles/ilios-common/shared/critical-notice.scss
Outdated
Show resolved
Hide resolved
michaelchadwick
force-pushed
the
6663-replace-critical-notice-sass-mixin
branch
2 times, most recently
from
1d808a0 to
9dd155c
Compare
stopfstedt
previously requested changes
Dec 2, 2025
packages/frontend/app/styles/components/update-notification.scss
Outdated
Show resolved
Hide resolved
…sses for instances where it is used
michaelchadwick
force-pushed
the
6663-replace-critical-notice-sass-mixin
branch
from
9dd155c to
3a08d68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs ilios/ilios#6608
Fixes ilios/ilios#6663
Removed the SASS mixin, creates a new class, and creates some subclasses for the instances where it was used, adding in their specific
background-color,color, andmin-heightparameters.