Skip to content

Conversation

@vitoksmile
Copy link
Contributor

Description

Show clear search button to reset search page to empty state.

Users can clear each filter individually on their own bottom sheets (e.g. Location chip opens "Select location" bottom sheet with "Clear button" which clears only the location).

How Has This Been Tested?

Case 1:

  • Open "Search" tab
  • Select any filter (e.g. Location)
  • The clear icon is displayed as suffix icon for the search text field

Case 2:

  • Open "Photos" tab
  • Select any photo
  • Scroll down (or click on menu icon) to open bottom sheet
  • Click on "View similar photos" action
  • The clear icon is displayed as suffix icon for the search text field

Screenshots

clear.search.mp4

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

No LLM

@shenlong-tanwen
Copy link
Member

The cross button on the text field is usually used to clear just the text and not all the filters. I wonder if this might get users confused. Maybe we can have a text button after the text field that says "Clear All"?

@vitoksmile
Copy link
Contributor Author

vitoksmile commented Nov 10, 2025

The cross button on the text field is usually used to clear just the text and not all the filters. I wonder if this might get users confused. Maybe we can have a text button after the text field that says "Clear All"?

sure, agree here

what if we add a new chip button "Clear All" in the same row where we have other filters (child button with the same style as applied filter)?

@shenlong-tanwen
Copy link
Member

what if we add a new chip button "Clear All" in the same row where we have other filters (child button with the same style as applied filter)?

You can experiment with different arrangements of the 'Clear All' button. I'd also bring in @alextran1502, who has much more expertise in UI/UX than I do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants