-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Closed
Description
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode states
You should avoid using this if possible; it's been deprecated for some time. Instead, you should use KeyboardEvent.code, if it's implemented. Unfortunately, some browsers still don't have it, so you'll have to be careful to make sure you use one which is supported on all target browsers.
event.keyCode shows up in places like
impress.js/src/plugins/navigation/navigation.js
Lines 95 to 107 in 9475720
| switch ( event.keyCode ) { | |
| case 33: // Pg up | |
| case 37: // Left | |
| case 38: // Up | |
| api.prev( event ); | |
| break; | |
| case 9: // Tab | |
| case 32: // Space | |
| case 34: // Pg down | |
| case 39: // Right | |
| case 40: // Down | |
| api.next( event ); | |
| break; |
Unless there are any objections I will fork and work toward a PR to fix this.
Metadata
Metadata
Assignees
Labels
No labels