Bump yarn to latest 4.x version, run build and prettier

Bump yarn to latest 4.x version, run build and prettier

Author: todowa

incident/.gitignore

@@ -2,3 +2,12 @@ node_modules
 package-lock.json
 dist
 dist-types
+
+# https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
+.pnp.*
+.yarn/*
+!.yarn/patches
+!.yarn/plugins
+!.yarn/releases
+!.yarn/sdks
+!.yarn/versions

incident/.yarn/releases/yarn-4.10.3.cjs

@@ -0,0 +1,7 @@
+compressionLevel: mixed
+
+enableGlobalCache: false
+
+nodeLinker: node-modules
+
+yarnPath: .yarn/releases/yarn-4.10.3.cjs

incident/.yarnrc.yml

@@ -60,9 +60,9 @@ export interface Config {
        */
       system?: string;
       /**
-      * The custom field ID that associated Group entities to incidents.
-      * @visibility frontend
-      */
+       * The custom field ID that associated Group entities to incidents.
+       * @visibility frontend
+       */
       group?: string;
     };
   };

incident/config.d.ts

@@ -20,7 +20,7 @@
   "sideEffects": false,
   "scripts": {
     "start": "backstage-cli package start",
-    "build": "backstage-cli package build",
+    "build": "npx tsc && backstage-cli package build",
     "lint": "backstage-cli package lint",
     "test": "backstage-cli package test",
     "clean": "backstage-cli package clean",

incident/package.json

@@ -6,12 +6,6 @@ First install dependencies:
 yarn
 ```
 
-Then transpile the Typescript:
-
-```shell
-yarn tsc
-```
-
 Now build the plugin:
 
 ```shell

incident/release.md

@@ -41,7 +41,7 @@ const DEFAULT_PROXY_PATH = "/incident/api";
 
 type Options = {
   discoveryApi: DiscoveryApi;
-  fetchApi: FetchApi,
+  fetchApi: FetchApi;
   proxyPath?: string;
 };
 

incident/src/api/client.ts

@@ -9,7 +9,8 @@ import { configApiRef, useApi } from "@backstage/core-plugin-api";
 
 export const HomePageIncidentCardContent = () => {
   const config = useApi(configApiRef);
-    const baseUrl = config.getOptionalString('incident.baseUrl') || "https://app.incident.io";
+  const baseUrl =
+    config.getOptionalString("incident.baseUrl") || "https://app.incident.io";
 
   const query = new URLSearchParams();
   query.set(`status_category[one_of]`, "active");

incident/src/components/HomePageIncidentCard/Content.tsx

@@ -20,7 +20,10 @@ import {
   discoveryApiRef,
   fetchApiRef,
 } from "@backstage/core-plugin-api";
-import {CardExtensionProps, createCardExtension} from "@backstage/plugin-home-react";
+import {
+  CardExtensionProps,
+  createCardExtension,
+} from "@backstage/plugin-home-react";
 
 import { IncidentApi, IncidentApiRef } from "./api/client";
 
@@ -29,8 +32,8 @@ export const incidentPlugin = createPlugin({
   apis: [
     createApiFactory({
       api: IncidentApiRef,
-      deps: { 
-        discoveryApi: discoveryApiRef, 
+      deps: {
+        discoveryApi: discoveryApiRef,
         fetchApi: fetchApiRef,
       },
       factory: ({ discoveryApi, fetchApi }) => {
@@ -55,7 +58,9 @@ export const EntityIncidentCard = incidentPlugin.provide(
   }),
 );
 
-export const HomePageIncidentCard: (props: CardExtensionProps<unknown>) => React.JSX.Element = incidentPlugin.provide(
+export const HomePageIncidentCard: (
+  props: CardExtensionProps<unknown>,
+) => React.JSX.Element = incidentPlugin.provide(
   createCardExtension({
     name: "HomePageIncidentCard",
     title: "Ongoing Incidents",