Skip to content

Commit 3833f7f

Browse files
authored
Merge pull request #28 from carrvo/dev/normalize-issuer
Looks good, thank you! 🎉
2 parents 341cdd4 + 0e15407 commit 3833f7f

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/IndieAuth/Client.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,7 @@ public static function validateIssuerMatch($params, $expected_issuer = '') {
535535
return new ErrorResponse('missing_iss', 'The authorization server did not return the iss parameter');
536536
}
537537

538-
if ($params['iss'] !== $expected_issuer) {
538+
if (self::normalizeMeURL($params['iss']) !== self::normalizeMeURL($expected_issuer)) {
539539
return new ErrorResponse('invalid_iss', 'The authorization server returned an invalid iss parameter');
540540
}
541541
}

tests/ClientTest.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,14 @@ public function testValidateIssuer()
7575
$this->assertNull($response);
7676
}
7777

78+
public function testValidateIssuerNormalizes()
79+
{
80+
$expected_issuer = 'https://issuer.example.com';
81+
$params = ['iss' => $expected_issuer];
82+
$response = Client::validateIssuerMatch($params, $expected_issuer.'/');
83+
$this->assertNull($response);
84+
}
85+
7886
public function testValidateIssuerMissing()
7987
{
8088
$expected_issuer = 'https://issuer.example.com/';

0 commit comments

Comments
 (0)