Skip to content

Add common aircraft frequencies to airport channel import - #141

Open
emuehlstein wants to merge 2 commits into
infamy:mainfrom
emuehlstein:feature/common-aircraft-frequencies
Open

Add common aircraft frequencies to airport channel import#141
emuehlstein wants to merge 2 commits into
infamy:mainfrom
emuehlstein:feature/common-aircraft-frequencies

Conversation

@emuehlstein

Copy link
Copy Markdown

Summary

Adds an optional set of common / itinerant aircraft frequencies (Guard, UNICOM, air-to-air, Multicom, SAR, etc.) to the Channel Wizard airport import flow. These are the itinerant frequencies listed on the RadioReference Aircraft wiki, useful to have alongside nearby airport channels.

What's included

  • Service (generateAirportChannels) — now accepts a selected subset of common frequencies instead of a boolean:
    • Single zone mode: common channels are appended to the Airports zone.
    • Individual zones mode (one per airport): common channels are placed in their own separate Aircraft zone.
    • Channels are receive-only (forbidTx, NO_TX_FREQUENCY), Analog, 25 kHz, High power — matching the existing airband channel pattern.
  • UI (AirportSource) — the "Add common aircraft frequencies" checkbox is now available in both zone-grouping modes. When enabled, a select/deselect list of all 16 frequencies is shown (all selected by default) with Select All / Deselect All buttons, and only the selected subset is added.
  • Tests — updated and expanded airportChannels.test.ts:
    • single-zone append to Airports
    • separate Aircraft zone in individual mode
    • partial subset selection
    • empty list adds nothing
    • common-frequency channels are receive-only
    • channel names ≤ 16 chars

Testing

  • npx vitest run tests/unit/airportChannels.test.ts17 passing.
  • Type-check / build clean.
  • Verified end-to-end in the browser against a real DM-32UV codeplug: searched near KLAX, selected the airport with common frequencies enabled in individual-zone mode, deselected 2 of 16, and confirmed generation of a 6-channel KLAX zone plus a separate 14-channel Aircraft zone.

Adds an optional set of common/itinerant aircraft frequencies (Guard, UNICOM, air-to-air, Multicom, SAR, etc.) to the Channel Wizard airport import flow.

- Service: generateAirportChannels now accepts a selected subset of common frequencies. In single-zone mode they are appended to the Airports zone; in individual-zone mode they are placed in a separate Aircraft zone. Channels are receive-only (forbidTx, Analog, 25kHz).
- UI: the 'Add common aircraft frequencies' checkbox is available in both zone-grouping modes, with a select/deselect list (all selected by default) plus Select All / Deselect All.
- Tests: updated and added coverage for single-zone append, separate Aircraft zone in individual mode, partial subset selection, empty list, and receive-only channels.
@infamy

infamy commented Jul 23, 2026

Copy link
Copy Markdown
Owner

It will make a build and deploy it to test environment... If you are ready and it looks good there let me know we can then merge it.

@infamy
infamy marked this pull request as ready for review July 28, 2026 05:39
@infamy infamy closed this Jul 28, 2026
@infamy infamy reopened this Jul 28, 2026
@infamy

infamy commented Jul 28, 2026

Copy link
Copy Markdown
Owner

/preview

@github-actions

Copy link
Copy Markdown

Mirrored for preview/deploy testing: #145

@infamy

infamy commented Jul 28, 2026

Copy link
Copy Markdown
Owner

https://neonplug.app/test/preview-pr-141/ <- so this way works.. I have to issue preview but that tells it to make a copy under me and deploy it for testing.

@github-actions

Copy link
Copy Markdown

Mirrored for CI/deploy testing: #145

Preview will be live at https://neonplug.app/test/preview-pr-141/ once the build finishes (usually a few minutes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants