Updated java options manage. Fixes #229 #231
Conversation
|
Difference between old and new opts list NEW Full lists OLD NEW |
|
extra java options are added at the end of the jvm args so user can override defaults extraJvmOpts: "-XX:MaxRAMPercentage=75.0" OLD NEW |
ryanemerson
left a comment
ryanemerson
left a comment
There was a problem hiding this comment.
There's a bunch of JAVA_ env variables in the image descriptor files that are no longer valid. I think we need to remove them as part of this PR.
| if [ -z "${CONTAINER_MAX_MEMORY:-}" ]; then | ||
| return | ||
| fi | ||
| source "$JBOSS_CONTAINER_UTIL_LOGGING_MODULE/logging.sh" |
There was a problem hiding this comment.
What does this script provide us?
There was a problem hiding this comment.
it provides logging facilities in case of debugging
| # This has forked (and diverged) from: | ||
| # at https://github.com/fabric8io/run-java-sh | ||
| # | ||
| # ========================================================== |
There was a problem hiding this comment.
Is this still relevant or are we using https://github.com/jboss-container-images/openjdk/blob/ubi9/modules/run/artifacts/opt/jboss/container/java/run/run-java.sh ?
There was a problem hiding this comment.
it's ported from the original script, I guess it can be removed from here
|
@ryanemerson do you think are we ok with the new GC settings? |
Crumby
left a comment
Crumby
left a comment
There was a problem hiding this comment.
@rigazilla There are some minor spacing issues in the PR and outdated JAVA vars in server-openjdk.yaml including JAVA_MAX_MEMORY_RATIO defaulting to 50%. That default has been changed for UBI9 OpenJDKs to 80% and I wonder if should let the default default to overtake for consistency.
I also wonder what documentation changes are required with this PR. If any.
| ## =================================================================================== | ||
| if [ -n "${DEBUG:-}" ]; then | ||
| set -x | ||
| set -x |
| init_limit_env_vars | ||
| # Echo options, trimming trailing and multiple spaces | ||
| echo "${JAVA_OPTIONS:-} $(calc_init_memory) $(calc_max_memory) $(diagnostics_options) $(gc_options)" | awk '$1=$1' | ||
| get_java_options |
3 participants
Updates java-opts.sh with the latest from run-java.sh
unfortunately run-java.sh funcs cannot be imported without execute the script, so copy is needed