Skip to content

Commit 09850e9

Browse files
Acat 3.12 release (#81)
* Remove pdbonly debug type from project files and set to none for release configurations * Refactor project files to unify Debug and Release configurations, removing x86 specific settings and ensuring consistent output paths and properties. * Refactor project files to unify Debug and Release configurations, ensuring consistent output paths and properties. * Add src/Redistributable/ to .gitignore to exclude redistributable files from version control * Update .gitmodules to specify the main branch for the ConvAssist submodule * Update configuration files to unset resource paths and standardize model names * Deleted unused dylib files from brainflow. (NO BINARIES FROM BRAINFLOW SHOULD BE IN THE REPO!) * Update .gitattributes to comment out LFS tracking for Setup files and modify .gitignore to include ACATSetup.exe * Update output paths and increment assembly version for ACAT applications * Latest build of ConvAssist. NOTE: This is DEBUG BUILD * Refactor ConvAssist initialization and named pipe server handling for improved clarity and performance * Update ConvAssist executable file size and hash for version tracking * Refactor ConvAssist named pipe server methods for improved error handling and clarity; update logging messages for consistency * Removing more unneeded files * Latest version of ConvAssist * Improve error handling in deploy.bat; add checks for source directory existence and remove unnecessary file copy commands * Enhance ConvAssist named pipe server functionality; add parameter handling for server creation and improve readiness checks in SendParams method. * Update ConvAssist executable and refactor logging methods for improved clarity; change file access mode in XmlFileSave method * Refactor ConvAssist initialization to include parameter sending; comment out factory default settings in GlobalPreferences * Update ConvAssist configuration and improve named pipe server timeout; adjust predictor class and clean up logging assertions * Update .gitignore to include internal ConvAssistApp directory and ConvAssist executable * removing lfs * Remove unused model files and configurations from ConvAssist * Update deploy.bat to use xcopy for deploying ConvAssistApp files * Refactor ConvAssistWordPredictor to conditionally start the ConvAssist process based on debug mode; clean up commented code and improve readability. * Remove ConvAssist submodule and related files; replace ConvAssist.exe with ConvAssist.zip in deployment script * Fix formatting in ConvAssistWordPredictor.cs for improved readability * Update .gitignore to include installer files and remove specific executable entries * Update .gitignore and deploy.bat for ConvAssistApp deployment; add ConvAssist directory check and expand zip if missing * Update ConvAssist.zip metadata and modify deploy.bat to remove error message for missing ConvAssist directory * Enable digital verification in project configurations and update deployment script to extract ConvAssist.zip directly to the source directory. * Adjust word suggestion settings in ACATPreferences for improved prediction accuracy * Update ConvAssist.zip metadata to reflect new file size and hash * Updated with latest 3.12 changes * Enhance deploy.bat to clear existing files in TARGETDIR before extraction * Refactor project files to remove TRACE definition and standardize ErrorReport settings * Fix deploy.bat to ensure ConvAssist.zip extracts correctly into the intended directory * Update ConvAssist.zip metadata to reflect new file size and hash * Refactor ConvAssist code to improve async handling and add timeout functionality; update .gitignore for internal directory * Add custom post-clean target to ACATTalk project for enhanced cleanup * Reduce suggestion limit in wordPredMode.ini from 100 to 5 for improved performance * Add nullable XML elements for Language and panel names in Preferences class * Implement thread-safe XML utility methods with locking; enhance error handling in XmlFileSave * Update ConvAssist.zip to new version with updated file size * Bump assembly version to 3.12 across multiple projects * Update ConvAssist.zip to new version with updated file size * Add ENABLE_DIGITAL_VERIFICATION and TRACE define to Release|AnyCPU project configurations. Fix for logging bug. * Standardize define constants to use uppercase for TRACE in project configurations
1 parent d4e8f94 commit 09850e9

File tree

116 files changed

+1089
-1107
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

116 files changed

+1089
-1107
lines changed

.gitattributes

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,5 @@ src/Applications/Install/en/WordPredictors/ConvAssist/aac_gpt2/* filter=lfs diff
1818
src/Applications/Install/en/WordPredictors/ConvAssist/DialoGPT-medium/* filter=lfs diff=lfs merge=lfs -text
1919
src/Applications/Install/en/WordPredictors/ConvAssist/multi-qa-MiniLM-L6-cos-v1/* filter=lfs diff=lfs merge=lfs -text
2020
src/Assets/Videos/* filter=lfs diff=lfs merge=lfs -text
21-
src/Setup/* filter=lfs diff=lfs merge=lfs -text
21+
# src/Setup/* filter=lfs diff=lfs merge=lfs -text
2222
src/3rdParty/*.* filter=lfs diff=lfs merge=lfs -text

.gitignore

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,9 @@ ClientBin/
230230
*.publishsettings
231231
orleans.codegen.cs
232232

233+
# src/Applications/Install/ConvAssistApp/_internal
234+
src/Applications/Install/ConvAssistApp/ConvAssist
235+
233236
# Including strong name files can present a security risk
234237
# (https://github.com/github/gitignore/pull/2483#issue-259490424)
235238
#*.snk
@@ -348,3 +351,10 @@ MigrationBackup/
348351

349352
# Ionide (cross platform F# VS Code tools) working folder
350353
.ionide/
354+
355+
src/Redistributable/
356+
357+
# Installer Stuff
358+
src/Setup/ACATSetup*.exe
359+
src/Setup/*.nsi
360+
src/Applications/Install/ConvAssistApp/ConvAssist

.gitmodules

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/ACAT.sln

Lines changed: 8 additions & 362 deletions
Large diffs are not rendered by default.

src/ACATResources/ACATResources.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@
3131
<WarningLevel>4</WarningLevel>
3232
</PropertyGroup>
3333
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
34-
<DebugType>pdbonly</DebugType>
34+
<DebugType>none</DebugType>
35+
<DefineConstants>TRACE;ENABLE_DIGITAL_VERIFICATION</DefineConstants>
3536
<Optimize>true</Optimize>
3637
<OutputPath>bin\Release\</OutputPath>
37-
<DefineConstants>TRACE</DefineConstants>
38-
<ErrorReport>prompt</ErrorReport>
38+
<ErrorReport>prompt</ErrorReport>
3939
<WarningLevel>4</WarningLevel>
4040
</PropertyGroup>
4141
<ItemGroup>

src/ACATResources/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,5 @@
3333
// You can specify all the values or you can default the Build and Revision Numbers
3434
// by using the '*' as shown below:
3535
// [assembly: AssemblyVersion("1.0.*")]
36-
[assembly: AssemblyVersion("3.10")]
37-
[assembly: AssemblyFileVersion("3.10")]
36+
[assembly: AssemblyVersion("3.12")]
37+
[assembly: AssemblyFileVersion("3.12")]

src/Applications/ACATConfig/ACATConfig.csproj

Lines changed: 4 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -26,40 +26,20 @@
2626
<DebugSymbols>true</DebugSymbols>
2727
<DebugType>full</DebugType>
2828
<Optimize>false</Optimize>
29-
<OutputPath>bin\Debug\</OutputPath>
29+
<OutputPath>..\AcatApp\bin\Debug\</OutputPath>
3030
<DefineConstants>DEBUG;TRACE</DefineConstants>
3131
<ErrorReport>prompt</ErrorReport>
3232
<WarningLevel>4</WarningLevel>
3333
</PropertyGroup>
3434
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
3535
<PlatformTarget>AnyCPU</PlatformTarget>
36-
<DebugType>pdbonly</DebugType>
36+
<DebugType>none</DebugType>
37+
<DefineConstants>TRACE;ENABLE_DIGITAL_VERIFICATION</DefineConstants>
3738
<Optimize>true</Optimize>
38-
<OutputPath>bin\Release\</OutputPath>
39-
<DefineConstants>TRACE</DefineConstants>
39+
<OutputPath>..\AcatApp\bin\Release\</OutputPath>
4040
<ErrorReport>prompt</ErrorReport>
4141
<WarningLevel>4</WarningLevel>
4242
</PropertyGroup>
43-
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
44-
<DebugSymbols>true</DebugSymbols>
45-
<OutputPath>..\ACATApp\bin\Debug\</OutputPath>
46-
<DefineConstants>DEBUG;TRACE</DefineConstants>
47-
<DebugType>full</DebugType>
48-
<PlatformTarget>x86</PlatformTarget>
49-
<ErrorReport>prompt</ErrorReport>
50-
<CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
51-
<Prefer32Bit>true</Prefer32Bit>
52-
</PropertyGroup>
53-
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|x86'">
54-
<OutputPath>..\ACATApp\bin\Release\</OutputPath>
55-
<DefineConstants>TRACE</DefineConstants>
56-
<Optimize>true</Optimize>
57-
<DebugType>pdbonly</DebugType>
58-
<PlatformTarget>x86</PlatformTarget>
59-
<ErrorReport>prompt</ErrorReport>
60-
<CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
61-
<Prefer32Bit>true</Prefer32Bit>
62-
</PropertyGroup>
6343
<PropertyGroup>
6444
<ApplicationIcon>Properties\ACATConfig.ico</ApplicationIcon>
6545
</PropertyGroup>

src/Applications/ACATConfig/Program.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
//
1111
////////////////////////////////////////////////////////////////////////////
1212

13-
//#define ENABLE_DIGITAL_VERIFICATION
14-
1513
using ACAT.Applications;
1614
using ACAT.Lib.Core.PanelManagement;
1715
using ACAT.Lib.Core.PreferencesManagement;
@@ -189,7 +187,7 @@ private static bool validateCertificate(String dllPath)
189187
catch (Exception ex)
190188
{
191189
MessageBox.Show("Digital signature verification failed for the following DLL.\n\n" + dllPath + "\n\n" + ex.Message, "Error", MessageBoxButtons.OK, MessageBoxIcon.Stop);
192-
return false;
190+
return false;
193191
}
194192

195193
return true;

src/Applications/ACATConfig/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@
3333
// You can specify all the values or you can default the Build and Revision Numbers
3434
// by using the '*' as shown below:
3535
// [assembly: AssemblyVersion("1.0.*")]
36-
[assembly: AssemblyVersion("3.11")]
37-
[assembly: AssemblyFileVersion("3.11")]
36+
[assembly: AssemblyVersion("3.12")]
37+
[assembly: AssemblyFileVersion("3.12")]
3838

src/Applications/ACATTalk/ACATTalk.csproj

Lines changed: 25 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
</SccAuxPath>
2424
<SccProvider>
2525
</SccProvider>
26-
<PublishUrl>publish\</PublishUrl>
2726
<Install>true</Install>
2827
<InstallFrom>Disk</InstallFrom>
2928
<UpdateEnabled>false</UpdateEnabled>
@@ -38,36 +37,34 @@
3837
<UseApplicationTrust>false</UseApplicationTrust>
3938
<BootstrapperEnabled>true</BootstrapperEnabled>
4039
</PropertyGroup>
41-
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|x86' ">
42-
<PlatformTarget>x86</PlatformTarget>
40+
<PropertyGroup>
41+
<ApplicationIcon>ACATTalk.ico</ApplicationIcon>
42+
</PropertyGroup>
43+
<PropertyGroup>
44+
<RunPostBuildEvent>OnOutputUpdated</RunPostBuildEvent>
45+
</PropertyGroup>
46+
<PropertyGroup />
47+
<PropertyGroup>
48+
<SignManifests>false</SignManifests>
49+
</PropertyGroup>
50+
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|AnyCPU'">
4351
<DebugSymbols>true</DebugSymbols>
44-
<DebugType>full</DebugType>
45-
<Optimize>false</Optimize>
4652
<OutputPath>..\ACATApp\bin\Debug\</OutputPath>
4753
<DefineConstants>DEBUG;TRACE</DefineConstants>
48-
<ErrorReport>prompt</ErrorReport>
49-
<WarningLevel>4</WarningLevel>
54+
<DebugType>full</DebugType>
55+
<PlatformTarget>AnyCPU</PlatformTarget>
5056
<UseVSHostingProcess>false</UseVSHostingProcess>
51-
<Prefer32Bit>false</Prefer32Bit>
57+
<LangVersion>7.3</LangVersion>
58+
<ErrorReport>prompt</ErrorReport>
5259
</PropertyGroup>
53-
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|x86' ">
54-
<PlatformTarget>x86</PlatformTarget>
55-
<DebugType>pdbonly</DebugType>
56-
<Optimize>true</Optimize>
60+
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|AnyCPU'">
5761
<OutputPath>..\ACATApp\bin\Release\</OutputPath>
58-
<DefineConstants>TRACE</DefineConstants>
62+
<Optimize>true</Optimize>
63+
<PlatformTarget>AnyCPU</PlatformTarget>
64+
<LangVersion>7.3</LangVersion>
5965
<ErrorReport>prompt</ErrorReport>
60-
<WarningLevel>4</WarningLevel>
61-
<AllowUnsafeBlocks>false</AllowUnsafeBlocks>
62-
<Prefer32Bit>false</Prefer32Bit>
63-
</PropertyGroup>
64-
<PropertyGroup>
65-
<ApplicationIcon>ACATTalk.ico</ApplicationIcon>
66-
</PropertyGroup>
67-
<PropertyGroup>
68-
<RunPostBuildEvent>Always</RunPostBuildEvent>
66+
<DefineConstants>TRACE;ENABLE_DIGITAL_VERIFICATION</DefineConstants>
6967
</PropertyGroup>
70-
<PropertyGroup />
7168
<ItemGroup>
7269
<Reference Include="ACATCore">
7370
<HintPath>..\..\Redistributable\ACATCore.dll</HintPath>
@@ -186,4 +183,9 @@
186183
<Target Name="AfterBuild">
187184
</Target>
188185
-->
186+
<Target Name="CustomPostClean" AfterTargets="Clean">
187+
<Message Text="Executing custom post-clean step..." Importance="high" />
188+
<!-- Add your custom tasks here -->
189+
<Delete Files="..\ACATApp\bin\$(Configuration)\*.*" />
190+
</Target>
189191
</Project>

0 commit comments

Comments
 (0)