read(_field)/write(_field): Make incurred implementations overridable
#394
Conversation
…rridable In particular, added documentation to note what the relevant template is to override the `write_register`/`read_register` implementations (which are no longer internal).
|
|
||
| template _reg_read_as_field is (register, read_register, read_field) { | ||
|
|
||
| template read_register_via_read_field is (register, read_register, |
There was a problem hiding this comment.
We may want to polish naming convention a bit. It is correct that write_register is instantiated via write_field, but the result of that is that the write_field method is called via the read_register method, i.e. an instance of "via" with reverse direction.
I haven't thought of a better name yet.
There was a problem hiding this comment.
Eliminating the ambiguity can be done by read_register_impl_via_read_field or read_register_impl_from_read_field. These are long and unwieldy... but at the same time, we don't expect people to use reference these very often, and having the name be documentation on its own has its virtue. I'm leaning towards this (specifically the one using "from"). Your opinion?
|
PR Verification: ✅ success |
3 participants
In particular, added documentation to note what the relevant template is to override the
write_register/read_registerimplementations (which are no longer internal).