Add support for IN2 rule

Author: alecalvop

src/analysis/parsing/parser.rs

@@ -369,8 +369,14 @@ impl <'a> FileParser<'a> {
                     self.advance();
                 },
                 TokenKind::Whitespace => {
-                    // TODO: this might not work correctly with tabs
-                    self.current_column += self.lexer.slice().len() as u32;
+                    let slice = self.lexer.slice();
+                    for ch in slice.chars() {
+                        if ch == '\t' {
+                            self.current_column += 4;
+                        } else {
+                            self.current_column += 1;
+                        }
+                    }
                     self.advance();
                 },
                 TokenKind::MultilineComment => {

src/lint/mod.rs

@@ -6,7 +6,7 @@ use serde::{Deserialize, Serialize};
 use rules::{instantiate_rules, CurrentRules};
 use rules::{spacing::{SpBraceOptions, SpPunctOptions, NspFunparOptions,
                       NspInparenOptions, NspUnaryOptions, NspTrailingOptions},
-                      indentation::{LongLineOptions, IN3Options,
+                      indentation::{LongLineOptions, IN2Options, IN3Options,
                                     IN9Options, ContinuationLineOptions},
                     };
 use crate::analysis::{DMLError, IsolatedAnalysis, LocalDMLError};
@@ -55,6 +55,8 @@ pub struct LintCfg {
     #[serde(default)]
     pub long_lines: Option<LongLineOptions>,
     #[serde(default)]
+    pub in2: Option<IN2Options>,
+    #[serde(default)]
     pub in3: Option<IN3Options>,
     #[serde(default)]
     pub continuation_line: Option<ContinuationLineOptions>,
@@ -74,6 +76,7 @@ impl Default for LintCfg {
             long_lines: Some(LongLineOptions {
                 max_length: MAX_LENGTH_DEFAULT,
                             }),
+            in2: Some(IN2Options{}),
             in3: Some(IN3Options{indentation_spaces: 4}),
             continuation_line: Some(ContinuationLineOptions {
                 indentation_spaces: INDENTATION_LEVEL_DEFAULT,
@@ -126,6 +129,7 @@ pub fn begin_style_check(ast: TopAst, file: String, rules: &CurrentRules) -> Res
     // Per line checks
     let lines: Vec<&str> = file.lines().collect();
     for (row, line) in lines.iter().enumerate() {
+        rules.in2.check(&mut linting_errors, row, line);
         rules.long_lines.check(&mut linting_errors, row, line);
         rules.nsp_trailing.check(&mut linting_errors, row, line);
     }

src/lint/rules/indentation.rs

@@ -59,6 +59,38 @@ impl Rule for LongLinesRule {
     }
 }
 
+#[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]
+pub struct IN2Options {}
+
+pub struct IN2Rule {
+    pub enabled: bool,
+}
+
+impl IN2Rule {
+    pub fn check(&self, acc: &mut Vec<LocalDMLError>, row: usize, line: &str) {
+        if !self.enabled { return; }
+        let rowu32 = row.try_into().unwrap();
+
+        for (col, _) in line.match_indices('\t') {
+            let colu32 = col.try_into().unwrap();
+            let msg = IN2Rule::description().to_owned();
+            let dmlerror = LocalDMLError {
+                range: Range::<ZeroIndexed>::from_u32(rowu32, rowu32, colu32, colu32 + 1),
+                description: msg,
+            };
+            acc.push(dmlerror);
+        }
+    }
+}
+impl Rule for IN2Rule {
+    fn name() -> &'static str {
+        "IN2"
+    }
+    fn description() -> &'static str {
+        "Tab characters (ASCII 9) should never be used to indent lines."
+    }
+}
+
 pub struct IN3Rule {
     pub enabled: bool,
     indentation_spaces: u32

src/lint/rules/mod.rs

@@ -7,7 +7,7 @@ pub mod tests;
 use spacing::{SpBracesRule,
     SpPunctRule, NspFunparRule, NspInparenRule,
     NspUnaryRule, NspTrailingRule};
-use indentation::{LongLinesRule, IN3Rule, IN9Rule, ContinuationLineRule};
+use indentation::{LongLinesRule, IN2Rule, IN3Rule, IN9Rule, ContinuationLineRule};
 use crate::lint::LintCfg;
 
 pub struct CurrentRules {
@@ -18,6 +18,7 @@ pub struct CurrentRules {
     pub nsp_unary: NspUnaryRule,
     pub nsp_trailing: NspTrailingRule,
     pub long_lines: LongLinesRule,
+    pub in2: IN2Rule,
     pub in3: IN3Rule,
     pub continuation_line: ContinuationLineRule,
     pub in9: IN9Rule
@@ -32,6 +33,7 @@ pub fn  instantiate_rules(cfg: &LintCfg) -> CurrentRules {
         nsp_unary: NspUnaryRule { enabled: cfg.nsp_unary.is_some() },
         nsp_trailing: NspTrailingRule { enabled: cfg.nsp_trailing.is_some() },
         long_lines: LongLinesRule::from_options(&cfg.long_lines),
+        in2: IN2Rule { enabled: cfg.in2.is_some() },
         in3: IN3Rule::from_options(&cfg.in3),
         continuation_line: ContinuationLineRule::from_options(&cfg.continuation_line),
         in9: IN9Rule::from_options(&cfg.in9),

src/lint/rules/tests/indentation/mod.rs

@@ -1,3 +1,4 @@
+pub mod in2;
 pub mod in3;
 pub mod in6;
 pub mod in9;