Optimizations in reference matching #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JonatanWaern
commented
Oct 15, 2025
JonatanWaern
commented
- Create a minimal constructor for Symbol and use it
- Remove unused enum
- Allow easier examination of uniqueness of Symbols
- Accumulate reference matches instead of returning
Signed-off-by: Jonatan Waern <[email protected]>
Signed-off-by: Jonatan Waern <[email protected]>
Assigns a global and unique ID to each symbol, stored together with it in its symbolref. Allowing us to efficiently perform EQ and Hash on symbolrefs without locking the actual ref Signed-off-by: Jonatan Waern <[email protected]>
Should be more efficient _and_ also results in cleaner code Signed-off-by: Jonatan Waern <[email protected]>
Signed-off-by: Jonatan Waern <[email protected]>
Signed-off-by: Jonatan Waern <[email protected]>
TSonono
approved these changes
Oct 20, 2025
TSonono
left a comment
TSonono
left a comment
There was a problem hiding this comment.
This is a fantastic improvement. Both in regard to memory usage, but most importantly the performance boost is huge! Great job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.