fix quantizedLinear layer feeds into src graph output #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayngun
approved these changes
Mar 13, 2025
|
@saurabhkale17 please update branch |
saurabhkale17
force-pushed
the
saurabh/stripping_issue
branch
from
5a0692d to
e1053ff
Compare
Author
|
I have rebase the branch @sfatimar |
sfatimar
approved these changes
Mar 18, 2025
ankitm3k
pushed a commit
that referenced
this pull request
Apr 1, 2025
ankitm3k
pushed a commit
that referenced
this pull request
Apr 1, 2025
ankitm3k
pushed a commit
that referenced
this pull request
Apr 2, 2025
ankitm3k
pushed a commit
that referenced
this pull request
Apr 4, 2025
ankitm3k
pushed a commit
that referenced
this pull request
Apr 9, 2025
ankitm3k
pushed a commit
that referenced
this pull request
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The QuantizedLinear node was being stripped off even when it was feeding into the graph output, which expected a quantized input. This occurred despite the presence of a check for QuantizedLinear feeding into src graph output. The root causes of this issue were:
Fix
This PR addresses both issues by:
This fix ensures that quantized models function correctly without unnecessary node removal, maintaining the integrity of the quantized computation.
https://jira.devtools.intel.com/browse/EISW-159866