ip_vs_service: fix add service failed when vip like 1:1:1:1:1:1:1:1 #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When vip is IPv6 and every in6.s6_addr32 is same(for example 1:1:1:1:1:1:1:1), inet_addr_fold will return 0, be considered as an error(bad ip protocol)
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where adding IPVS services fails when the IPv6 VIP has a specific pattern where all 32-bit segments are identical (e.g., 1:1:1:1:1:1:1:1). The issue occurred because inet_addr_fold returns 0 for such addresses, which was incorrectly interpreted as an invalid IP protocol.
Key changes:
- Replace IP protocol validation logic to check address family directly instead of relying on
inet_addr_foldreturn value - Fix error handling in service addition to properly clean up on hash failures
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ywc689
added
the
pr/to-review-codes
ywc689
approved these changes
Sep 16, 2025
ytwang0320
added
pr/codes-reviewed-ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When vip is IPv6 and every in6.s6_addr32 is same(for example 1:1:1:1:1:1:1:1), inet_addr_fold will return 0, be considered as an error(bad ip protocol)