[RELEASE] iText 7 Core - 7.1.14

https://github.com/itext/itext7/releases/tag/7.1.14

* release/7.1.14:
  [RELEASE] 7.1.14
  Add unit tests for SvgCoordinateUtils
  Clean up manual porting for java's Matcher
  Restore lost tests introduced in DEVSIX-4682
  Support 'patternTransform' attribute for SVG pattern element
  Add support to utf-8 image format in svg
  Support 'viewbox' and `preserveAspectRatio' attribute for SVG pattern element
  Add test on second time signing document
  Add tests for SVG moveTo followed by multiple pairs
  Refactor text renderers sequence word wrapping logic
  Separate text sequence reset logic for robustness
  Support overflow-wrap: break-word/anywhere in case of the not fitting single glyph
  Remove floats skipping logic in span-wrapping: now floats break text sequence
  Support word-break property
  Support minMaxWidth counting for span- and special scripts wrapping
  Change condition to stop TextRenderer#layout when a width limit is reached
  Text elements wrapping support
  Add missing copyright headers
  Fix dummy log messages when we are processing xlink href with data
  Improve test coverage for StopSvgNodeRenderer class
  Add missing copyright headers
  Add PdfObjectReleaseTest class
  Add tests with all options of preserveAspectRation in svg element
  Add missing copyright headers
  Add tests with relative units in attributes of svg elements
  Add tests for absolutely positioned elements added to Canvas
  Fix javadoc
  Add stroke-width into inheritable set of svg attributes, update cmp files
  Upgrade BouncyCastle version to 1.67
  Fix javadoc warnings
  Add KeepTogetherTest#keepTogetherInDivWithKidsFloatTest
  Support 'objectBoundingBox' value for SVG pattern element 'patternContentUnits' and 'patternUnits'
  Unify the resource folder for HighlightItemsTest class
  Add form field borders support
  Add JavaDocs to unsupported AreaBreakRenderer methods
  Add support of pages target-counter(s). Finalize whole target-counter logic
  Add missing copyright headers
  Implement non-page(s) target-counter(s)
  Matcher tests
  Add initial support of SVG pattern element
  Configure dependency-check-maven to connect to a central database
  Support overflow-x for special scripts
  Support css overflow-wrap property
  Update veraPDF version in pdftest module
  Update printed links in CompareTool
  Update CONTRIBUTING.md with latest information and links
  Update BouncyCastle version to 1.66
  Divide the CssUtils class into several classes
  Move HighlightItemsTest from samples-internal repository
  Update slf4j version from 1.7.13 to 1.7.30
  Delete TODO related to clossed ticket
  Add intergration tests reproducing keep-together causing content overlap
  Make mutable final sets unmodifable
  Add XXEVulnerabilityTest class
  Add new tests for PdfTextExtractor
  Speed up PdfPagesTest#randomNumberPagesTest()
  Add missing copyright headers
  Implement target-counter for page
  Revert "Update junit version"
  Update junit version
  Update Java version from 1.7 to 1.8
  Remove TODO related to closed DEVSIX-2785
  Get rid of TODOs not related to Jira tickets in SignatureUtil
  BlockRenderer keep together for clear child element fix
  Add tests for keep-together elements in collaboration with floats wrapped into non-floating element
  Add intedration tests for svg pattern element
  Add missing copyright headers
  Add support of font-relative units for the font-size property
  Fix NPE in CanvasTag#getActualText() in case properties are missing
  Improve javadocs in svg and xml-parser modules
  Update japicmp version to 0.14.4
  Add missing copyright headers
  Improving test coverage for PdfFont class
  Fix javadoc warnings
  Remove package-info.java
  Fix JavaDoc warnings in several classes
  Fix javadoc warnings in PdfExplicitDestination and in PdfExplicitRemoteGoToDestination
  Remove itext5 verison tag from root pom file
  [AFTER RELEASE] 7.1.13
  Allow fetching of OTF language records by tag
  Add tests on default font-size and inheritance inside TSpan element
  Add missing copyright headers
  Fix overflow in OTF readCoverageFormat() DEVSIX-4642

Author: iText-CI

CONTRIBUTING.md

@@ -68,8 +68,7 @@ Before you submit your pull request consider the following guidelines:
 * Verify that your proposed change hasn't already been addressed in the develop branch.
 * Don't send a separate pull request for every single file you change.  
 * Please sign the [iText Contributor License Agreement (iCLA)](#cla) before sending pull
-  requests for any change of more than 20 significant lines of code (we're not counting curly braces and other syntactical sugar).
-  We cannot accept code without this agreement.
+  requests. We cannot accept code without this agreement.
 * Fork the iText repository on GitHub.
 * Clone your iText fork to your local machine.
 * Make your changes, **including appropriate test cases**.
@@ -100,8 +99,7 @@ To ensure consistency throughout the source code, keep these rules in mind as yo
 
 * We develop in Java first, and then port to .NET, so code submissions in Java are preferred.
   Nevertheless this shouldn't stop you from making a good pull request to the .NET port.
-* All Java code **must** be Java 7. Sorry, no lambda expressions or other Java 8 language features.
-* All features or bug fixes **must be tested** by one or more [unit tests][unit-testing].
+* All features or bug fixes **must be tested** by one or more unit tests.
 * All public API methods **must be documented** with JavaDoc. To see how we document our APIs, please check
   out the existing [javadocs][javadocs].
 * We follow the rules contained in
@@ -151,8 +149,7 @@ reference JIRA or GitHub issues that this commit **Closes**.
 
 ## <a name="cla">Signing the iCLA</a>
 
-Please sign the **iText Contributor License Agreement (iCLA)** before sending pull requests. For any larger code
-changes (more than 20 lines of significant code) to be accepted, the iCLA must be signed. It's a quick process, we promise!
+Please sign the [**iText Contributor License Agreement (iCLA)**][cla] before sending pull requests. For any code changes to be accepted, the iCLA must be signed. It's a quick process, we promise!
 
 We'll need you to [(digitally) sign and then email, fax or mail the form][cla].
 
@@ -165,18 +162,17 @@ We use the [Stack Exchange][stackoverflow] network for free support and [GitHub]
 * StackExchange: [http://stackexchange.com/legal](http://stackexchange.com/legal)
 * Github: [https://help.github.com/articles/github-terms-of-service/](https://help.github.com/articles/github-terms-of-service/)
 
-[cla]: http://itextpdf.com/policy
+[cla]: https://itextpdf.com/en/how-buy/legal/itext-contributor-license-agreement
 [coc]: CODE_OF_CONDUCT.md
 [github]: https://github.com/itext/itext7
-[java-style-guide]: http://www.oracle.com/technetwork/java/codeconvtoc-136057.html
-[javadocs]: http://itextpdf.com/api
+[java-style-guide]: https://www.oracle.com/technetwork/java/codeconvtoc-136057.html
+[javadocs]: https://itextpdf.com/api
 [pull]: https://github.com/itext/itext7/pulls
 [sscce]: http://sscce.org/
-[stackoverflow]: http://stackoverflow.com/questions/tagged/itext7
-[good-questions]: http://stackoverflow.com/help/how-to-ask
-[mcve]: http://stackoverflow.com/help/mcve
-[support]: http://itextpdf.com/support
-[unit-testing]: http://junit.org/
+[stackoverflow]: https://stackoverflow.com/questions/tagged/itext7
+[good-questions]: https://stackoverflow.com/help/how-to-ask
+[mcve]: https://stackoverflow.com/help/mcve
+[support]: https://itextpdf.com/support
 [git-commit]: https://chris.beams.io/posts/git-commit/
 [git-commit-separate]: https://chris.beams.io/posts/git-commit/#separate
 [git-commit-limit-50]: https://chris.beams.io/posts/git-commit/#limit-50

barcodes/pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>com.itextpdf</groupId>
     <artifactId>root</artifactId>
-    <version>7.1.13</version>
+    <version>7.1.14</version>
   </parent>
   <artifactId>barcodes</artifactId>
   <name>iText 7 - barcodes</name>

barcodes/src/main/java/com/itextpdf/barcodes/qrcode/QRCodeWriter.java

@@ -60,7 +60,7 @@ public final class QRCodeWriter {
      * @param width width of the QR-code
      * @param height height of the QR-code
      * @return 2D Greyscale map containing the visual representation of the QR-code, stored as a Bytematrix
-     * @throws WriterException
+     * @throws WriterException exception is thrown in case an error occurs when encoding a barcode using the Writer framework
      */
     public ByteMatrix encode(String contents, int width, int height)
             throws WriterException {
@@ -76,7 +76,7 @@ public ByteMatrix encode(String contents, int width, int height)
      * @param height height of the QR-code
      * @param hints Map containing suggestions for error-correction level and version
      * @return 2D Greyscale map containing the visual representation of the QR-code, stored as a Bytematrix
-     * @throws WriterException
+     * @throws WriterException exception is thrown in case an error occurs when encoding a barcode using the Writer framework
      */
     public ByteMatrix encode(String contents, int width, int height,
                              Map<EncodeHintType,Object> hints) throws WriterException {

font-asian/pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>com.itextpdf</groupId>
     <artifactId>root</artifactId>
-    <version>7.1.13</version>
+    <version>7.1.14</version>
   </parent>
   <artifactId>font-asian</artifactId>
   <name>iText 7 - Asian fonts</name>

forms/pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>com.itextpdf</groupId>
     <artifactId>root</artifactId>
-    <version>7.1.13</version>
+    <version>7.1.14</version>
   </parent>
   <artifactId>forms</artifactId>
   <name>iText 7 - forms</name>

forms/src/main/java/com/itextpdf/forms/fields/PdfFormField.java

@@ -44,6 +44,7 @@ This file is part of the iText (R) project.
 package com.itextpdf.forms.fields;
 
 import com.itextpdf.forms.PdfAcroForm;
+import com.itextpdf.forms.fields.borders.FormBorderFactory;
 import com.itextpdf.forms.util.DrawingUtil;
 import com.itextpdf.io.LogMessageConstant;
 import com.itextpdf.io.codec.Base64;
@@ -89,6 +90,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.pdf.xobject.PdfImageXObject;
 import com.itextpdf.layout.Canvas;
 import com.itextpdf.layout.Style;
+import com.itextpdf.layout.borders.Border;
 import com.itextpdf.layout.element.Div;
 import com.itextpdf.layout.element.Paragraph;
 import com.itextpdf.layout.element.Text;
@@ -2058,13 +2060,7 @@ public PdfFormField setBorderWidth(float borderWidth) {
     }
 
     public PdfFormField setBorderStyle(PdfDictionary style) {
-        //PdfDictionary bs = getWidgets().get(0).getBorderStyle();
         getWidgets().get(0).setBorderStyle(style);
-//        if (bs == null) {
-//            bs = new PdfDictionary();
-//            put(PdfName.BS, bs);
-//        }
-//        bs.put(PdfName.S, style);
         regenerateField();
         return this;
     }
@@ -2670,29 +2666,27 @@ protected void drawBorder(PdfCanvas canvas, PdfFormXObject xObject, float width,
         }
 
         if (backgroundColor != null) {
-            canvas.
-                    setFillColor(backgroundColor).
-                    rectangle(0, 0, width, height).
-                    fill();
+            canvas
+                    .setFillColor(backgroundColor)
+                    .rectangle(0, 0, width, height)
+                    .fill();
         }
 
         if (borderWidth > 0 && borderColor != null) {
             borderWidth = Math.max(1, borderWidth);
-            canvas.
-                    setStrokeColor(borderColor).
-                    setLineWidth(borderWidth);
-            if (bs != null) {
-                PdfName borderType = bs.getAsName(PdfName.S);
-                if (borderType != null && borderType.equals(PdfName.D)) {
-                    PdfArray dashArray = bs.getAsArray(PdfName.D);
-                    int unitsOn = dashArray != null ? (dashArray.size() > 0 ? (dashArray.getAsNumber(0) != null ? dashArray.getAsNumber(0).intValue() : 3) : 3) : 3;
-                    int unitsOff = dashArray != null ? (dashArray.size() > 1 ? (dashArray.getAsNumber(1) != null ? dashArray.getAsNumber(1).intValue() : unitsOn) : unitsOn) : unitsOn;
-                    canvas.setLineDash(unitsOn, unitsOff, 0);
-                }
+            canvas
+                    .setStrokeColor(borderColor)
+                    .setLineWidth(borderWidth);
+            Border border = FormBorderFactory.getBorder(bs, borderWidth, borderColor, backgroundColor);
+            if (border != null) {
+                float borderWidthX2 = borderWidth + borderWidth;
+                border.draw(canvas, new Rectangle(borderWidth, borderWidth,
+                        width - borderWidthX2, height - borderWidthX2));
+            } else {
+                canvas
+                        .rectangle(0, 0, width, height)
+                        .stroke();
             }
-            canvas.
-                    rectangle(0, 0, width, height).
-                    stroke();
         }
 
         applyRotation(xObject, height, width);

svg/src/main/java/com/itextpdf/svg/utils/SvgRegexUtils.java renamed to forms/src/main/java/com/itextpdf/forms/fields/borders/AbstractFormBorder.java

@@ -1,7 +1,8 @@
 /*
+
     This file is part of the iText (R) project.
     Copyright (c) 1998-2020 iText Group NV
-    Authors: iText Software.
+    Authors: Bruno Lowagie, Paulo Soares, et al.
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU Affero General Public License version 3
@@ -40,19 +41,33 @@ This file is part of the iText (R) project.
     For more information, please contact iText Software Corp. at this
     address: [email protected]
  */
-package com.itextpdf.svg.utils;
+package com.itextpdf.forms.fields.borders;
 
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
+import com.itextpdf.kernel.colors.Color;
+import com.itextpdf.layout.borders.Border;
 
-/**
- * This file is a helper class for internal usage only.
- * Be aware that its API and functionality may be changed in future.
- */
-public class SvgRegexUtils {
+abstract class AbstractFormBorder extends Border {
+
+    /**
+     * The form underline border.
+     *
+     * @see com.itextpdf.forms.fields.borders.UnderlineBorder
+     */
+    static final int FORM_UNDERLINE = 1001;
+    /**
+     * The form beveled border.
+     *
+     * @see com.itextpdf.forms.fields.borders.BeveledBorder
+     */
+    static final int FORM_BEVELED = 1002;
+    /**
+     * The form inset border.
+     *
+     * @see com.itextpdf.forms.fields.borders.InsetBorder
+     */
+    static final int FORM_INSET = 1003;
 
-    public static boolean containsAtLeastOneMatch(Pattern regexPattern, String stringToExamine){
-        Matcher matcher = regexPattern.matcher(stringToExamine);
-        return matcher.find();
+    protected AbstractFormBorder(Color color, float width) {
+        super(color, width);
     }
 }

forms/src/main/java/com/itextpdf/forms/fields/borders/BeveledBorder.java

@@ -0,0 +1,120 @@
+/*
+
+    This file is part of the iText (R) project.
+    Copyright (c) 1998-2020 iText Group NV
+    Authors: Bruno Lowagie, Paulo Soares, et al.
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU Affero General Public License version 3
+    as published by the Free Software Foundation with the addition of the
+    following permission added to Section 15 as permitted in Section 7(a):
+    FOR ANY PART OF THE COVERED WORK IN WHICH THE COPYRIGHT IS OWNED BY
+    ITEXT GROUP. ITEXT GROUP DISCLAIMS THE WARRANTY OF NON INFRINGEMENT
+    OF THIRD PARTY RIGHTS
+
+    This program is distributed in the hope that it will be useful, but
+    WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+    or FITNESS FOR A PARTICULAR PURPOSE.
+    See the GNU Affero General Public License for more details.
+    You should have received a copy of the GNU Affero General Public License
+    along with this program; if not, see http://www.gnu.org/licenses or write to
+    the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+    Boston, MA, 02110-1301 USA, or download the license from the following URL:
+    http://itextpdf.com/terms-of-use/
+
+    The interactive user interfaces in modified source and object code versions
+    of this program must display Appropriate Legal Notices, as required under
+    Section 5 of the GNU Affero General Public License.
+
+    In accordance with Section 7(b) of the GNU Affero General Public License,
+    a covered work must retain the producer line in every PDF that is created
+    or manipulated using iText.
+
+    You can be released from the requirements of the license by purchasing
+    a commercial license. Buying such a license is mandatory as soon as you
+    develop commercial activities involving the iText software without
+    disclosing the source code of your own applications.
+    These activities include: offering paid services to customers as an ASP,
+    serving PDFs on the fly in a web application, shipping iText with a closed
+    source product.
+
+    For more information, please contact iText Software Corp. at this
+    address: [email protected]
+ */
+package com.itextpdf.forms.fields.borders;
+
+import com.itextpdf.kernel.colors.Color;
+import com.itextpdf.kernel.colors.ColorConstants;
+import com.itextpdf.kernel.colors.DeviceCmyk;
+import com.itextpdf.kernel.colors.DeviceGray;
+import com.itextpdf.kernel.colors.DeviceRgb;
+import com.itextpdf.kernel.pdf.canvas.PdfCanvas;
+import com.itextpdf.layout.borders.SolidBorder;
+
+class BeveledBorder extends AbstractFormBorder {
+
+    private final Color backgroundColor;
+
+    public BeveledBorder(Color color, float width, Color backgroundColor) {
+        super(color, width);
+        this.backgroundColor = backgroundColor;
+    }
+
+    /**
+     * {@inheritDoc}
+     */
+    @Override
+    public void draw(PdfCanvas canvas, float x1, float y1, float x2, float y2, Side defaultSide,
+            float borderWidthBefore, float borderWidthAfter) {
+        SolidBorder solidBorder = new SolidBorder(getColor(), width);
+        solidBorder.draw(canvas, x1, y1, x2, y2, defaultSide, borderWidthBefore, borderWidthAfter);
+        float borderWidth = getWidth();
+        float borderWidthX2 = borderWidth + borderWidth;
+        Color darkerBackground = backgroundColor != null ? getDarkerColor(backgroundColor) : ColorConstants.LIGHT_GRAY;
+        if (Side.TOP.equals(defaultSide)) {
+            solidBorder = new SolidBorder(ColorConstants.WHITE, borderWidth);
+            solidBorder.draw(canvas, borderWidthX2, y1 - borderWidth, x2 - borderWidth,
+                    y2 - borderWidth, Side.TOP, borderWidth, borderWidth);
+        } else if (Side.BOTTOM.equals(defaultSide)) {
+            solidBorder = new SolidBorder(darkerBackground, borderWidth);
+            solidBorder.draw(canvas, x1 - borderWidth, borderWidthX2, borderWidthX2, borderWidthX2,
+                    Side.BOTTOM, borderWidth, borderWidth);
+        } else if (Side.LEFT.equals(defaultSide)) {
+            solidBorder = new SolidBorder(ColorConstants.WHITE, borderWidth);
+            solidBorder.draw(canvas, borderWidthX2, borderWidthX2, borderWidthX2, y2 - borderWidth,
+                    Side.LEFT, borderWidth, borderWidth);
+        } else if (Side.RIGHT.equals(defaultSide)) {
+            solidBorder = new SolidBorder(darkerBackground, borderWidth);
+            solidBorder.draw(canvas, x1 - borderWidth, y1 - borderWidth,
+                    x2 - borderWidth, borderWidthX2, Side.RIGHT, borderWidth, borderWidth);
+        }
+    }
+
+    /**
+     * {@inheritDoc}
+     */
+    @Override
+    public void drawCellBorder(PdfCanvas canvas, float x1, float y1, float x2, float y2, Side defaultSide) {
+        throw new UnsupportedOperationException();
+    }
+
+    /**
+     * {@inheritDoc}
+     */
+    @Override
+    public int getType() {
+        return AbstractFormBorder.FORM_BEVELED;
+    }
+
+    private Color getDarkerColor(Color color) {
+        if (color instanceof DeviceRgb) {
+            return DeviceRgb.makeDarker((DeviceRgb) color);
+        } else if (color instanceof DeviceCmyk) {
+            return DeviceCmyk.makeDarker((DeviceCmyk) color);
+        } else if (color instanceof DeviceGray) {
+            return DeviceGray.makeDarker((DeviceGray) color);
+        } else {
+            return color;
+        }
+    }
+}