users: remove check for offline mode (#342)

Author: itzg

src/main/java/me/itzg/helpers/users/ManageUsersCommand.java

@@ -69,9 +69,6 @@ public class ManageUsersCommand implements Callable<Integer> {
     @Option(names = {"-f", "--input-is-file"})
     boolean inputIsFile;
 
-    @Option(names = "--offline", description = "Disable API conversion of usernames to UUID")
-    boolean offline;
-
     @Option(names = "--mojang-api-base-url", defaultValue = "${env:MOJANG_API_BASE_URL:-https://api.mojang.com/}")
     String mojangApiBaseUrl;
 
@@ -241,10 +238,6 @@ private JavaUser resolveJavaUserId(SharedFetch sharedFetch, List<? extends JavaU
             }
         }
 
-        if (offline) {
-            throw new InvalidParameterException("Unable to resolve username while offline: " + input);
-        }
-
         return resolveUserFromApi(sharedFetch, input);
     }
 

src/test/java/me/itzg/helpers/users/ManageUsersCommandTest.java

@@ -1,6 +1,5 @@
 package me.itzg.helpers.users;
 
-import static com.github.stefanbirkner.systemlambda.SystemLambda.tapSystemErr;
 import static com.github.tomakehurst.wiremock.client.WireMock.*;
 import static org.assertj.core.api.Assertions.assertThat;
 import static uk.org.webcompere.modelassert.json.JsonAssertions.assertJson;
@@ -12,7 +11,6 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.Collections;
-import me.itzg.helpers.errors.ExitCodeMapper;
 import org.intellij.lang.annotations.Language;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
@@ -397,70 +395,6 @@ void givenUuidsAndAllExist(WireMockRuntimeInfo wmInfo) throws IOException {
             verify(0, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user1")));
             verify(0, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user2")));
         }
-
-        @Test
-        void offline(WireMockRuntimeInfo wmInfo) {
-            setupUserStubs();
-
-            final Path expectedFile = tempDir.resolve("whitelist.json");
-
-            final int exitCode = new CommandLine(
-                new ManageUsersCommand()
-            )
-                .execute(
-                    "--mojang-api-base-url", wmInfo.getHttpBaseUrl(),
-                    "--type", "JAVA_WHITELIST",
-                    "--output-directory", tempDir.toString(),
-                    "--offline",
-                    // mix of ID and UUIDs
-                    USER1_ID, USER2_UUID
-                );
-
-            assertThat(exitCode).isEqualTo(0);
-
-            assertThat(expectedFile).exists();
-
-            assertJson(expectedFile)
-                .isArrayContainingExactlyInAnyOrder(
-                    conditions()
-                        .satisfies(conditions()
-                            // names should be retained from existing file
-                            .at("/name").hasValue("")
-                            .at("/uuid").hasValue(USER1_UUID)
-                        )
-                        .satisfies(conditions()
-                            .at("/name").hasValue("")
-                            .at("/uuid").hasValue(USER2_UUID)
-                        )
-                );
-
-            verify(0, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user1")));
-            verify(0, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user2")));
-        }
-
-        @Test
-        void offlineFailsGivenName(WireMockRuntimeInfo wmInfo) throws Exception {
-            setupUserStubs();
-
-            final String err = tapSystemErr(() -> {
-                final int exitCode = new CommandLine(
-                    new ManageUsersCommand()
-                )
-                    .setExitCodeExceptionMapper(new ExitCodeMapper())
-                    .execute(
-                        "--mojang-api-base-url", wmInfo.getHttpBaseUrl(),
-                        "--type", "JAVA_WHITELIST",
-                        "--output-directory", tempDir.toString(),
-                        "--offline",
-                        "user1"
-                    );
-
-                assertThat(exitCode).isEqualTo(ExitCode.USAGE);
-            });
-
-            assertThat(err).contains("Unable to resolve username while offline: user1");
-        }
-
     }
 
     @Nested