Allow configuring the porkbun's client timeout (#75)

Author: jadolg

config.go

@@ -3,6 +3,7 @@ package main
 import (
 	"fmt"
 	"os"
+	"time"
 
 	"gopkg.in/yaml.v3"
 )
@@ -30,6 +31,7 @@ type configuration struct {
 	UpdateIntervalMinutes int                           `yaml:"update_interval_minutes"`
 	PorkbunCredentials    map[string]PorkbunCredentials `yaml:"credentials"`
 	Metrics               MetricsConfig                 `yaml:"metrics"`
+	Timeout               time.Duration                 `yaml:"timeout"`
 }
 
 func getConfig(configFile string) (configuration, error) {
@@ -58,6 +60,14 @@ func getConfig(configFile string) (configuration, error) {
 		}
 	}
 
+	if c.Timeout == 0 {
+		c.Timeout = 10 * time.Second
+	}
+
+	if c.UpdateIntervalMinutes == 0 {
+		c.UpdateIntervalMinutes = 5
+	}
+
 	return c, nil
 }
 

example.config.yaml

@@ -1,4 +1,5 @@
 update_interval_minutes: 5
+timeout: 20s
 
 credentials:
   prod:

main.go

@@ -75,7 +75,7 @@ func configureLogs(logLevel string) error {
 }
 
 func updateRecords(c configuration) {
-	clients, err := getPorkbunClients(c.PorkbunCredentials)
+	clients, err := getPorkbunClients(c.PorkbunCredentials, c.Timeout)
 	if err != nil {
 		log.Fatal(err)
 	}

porkbun.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 	"fmt"
 	"strconv"
+	"time"
 
 	"github.com/nrdcg/porkbun"
 	log "github.com/sirupsen/logrus"
@@ -68,11 +69,11 @@ func getRecords(ctx context.Context, domain, host string, client *porkbun.Client
 	return &ipv4Record, &ipv6Record, nil
 }
 
-func getPorkbunClients(credentials map[string]PorkbunCredentials) (map[string]*porkbun.Client, error) {
+func getPorkbunClients(credentials map[string]PorkbunCredentials, timeout time.Duration) (map[string]*porkbun.Client, error) {
 	clients := make(map[string]*porkbun.Client)
 
 	for key, credential := range credentials {
-		client, err := getPorkbunClient(credential, key)
+		client, err := getPorkbunClient(credential, key, timeout)
 		if err != nil {
 			connectionErrorsTotal.Inc()
 			log.Errorf("Error getting client for credentials '%s': %v", key, err)
@@ -83,9 +84,9 @@ func getPorkbunClients(credentials map[string]PorkbunCredentials) (map[string]*p
 	return clients, nil
 }
 
-func getPorkbunClient(credentials PorkbunCredentials, credentialsName string) (*porkbun.Client, error) {
+func getPorkbunClient(credentials PorkbunCredentials, credentialsName string, timeout time.Duration) (*porkbun.Client, error) {
 	client := porkbun.New(credentials.PorkbunSecretKey, credentials.PorkbunAPIKey)
-
+	client.HTTPClient.Timeout = timeout
 	ctx := context.Background()
 
 	yourIP, err := client.Ping(ctx)