Replace '.' with '_' in prometheus

Signed-off-by: Harshil Gupta <[email protected]>

Author: wololowarrior

internal/storage/metricstore/elasticsearch/reader_test.go

@@ -1002,7 +1002,7 @@ func TestGetCallRateBucketsToPoints_ErrorCases(t *testing.T) {
 	}
 }
 
-func TestGetLabelValues(t *testing.T) {
+func TestGetAttributeValues(t *testing.T) {
 	// Define test cases to cover various scenarios
 	testCases := []struct {
 		name           string
@@ -1219,7 +1219,7 @@ func compareBoolQuery(t *testing.T, expected, actual map[string]any) {
 		// Handle the case where actual filter is either array or single object
 		actualFilter, exists := actualBool["filter"]
 		if !exists {
-			t.Errorf("Expected filter but not found in actual query")
+			t.Error("Expected filter but not found in actual query")
 			return
 		}
 

internal/storage/metricstore/elasticsearch/testdata/output_attribute_key_values.json

@@ -63,4 +63,4 @@
       "path_3": {}
     }
   }
-}
+}

internal/storage/metricstore/prometheus/metricstore/reader.go

@@ -264,7 +264,7 @@ func (m MetricsReader) GetAttributeValues(ctx context.Context, params *metricsto
 	defer span.End()
 
 	span.SetAttributes(
-		attribute.String("label_name", params.AttributeKey),
+		attribute.String("attribute_name", params.AttributeKey),
 		attribute.String("service", params.ServiceName),
 	)
 	// Build match[] selectors to filter by service names if provided
@@ -273,7 +273,8 @@ func (m MetricsReader) GetAttributeValues(ctx context.Context, params *metricsto
 		matchers = append(matchers, fmt.Sprintf("{service_name=%q}", params.ServiceName))
 	}
 
-	values, warnings, err := m.client.LabelValues(ctx, params.AttributeKey, matchers, time.Time{}, time.Time{})
+	escapedKey := strings.ReplaceAll(params.AttributeKey, ".", "_")
+	values, warnings, err := m.client.LabelValues(ctx, escapedKey, matchers, time.Time{}, time.Time{})
 	if err != nil {
 		span.RecordError(err)
 		span.SetStatus(codes.Error, err.Error())

internal/storage/metricstore/prometheus/metricstore/reader_test.go

@@ -1015,7 +1015,7 @@ func assertMetrics(t *testing.T, gotMetrics *metrics.MetricFamily, wantLabels ma
 	assert.InDelta(t, float64(9223372036854), actualVal, 0.01)
 }
 
-func TestGetLabelValues(t *testing.T) {
+func TestGetAttributeValues(t *testing.T) {
 	for _, tc := range []struct {
 		name                string
 		labelName           string
@@ -1031,7 +1031,7 @@ func TestGetLabelValues(t *testing.T) {
 			name:                "get span_kind values for a specific service",
 			labelName:           "span_kind",
 			serviceName:         "emailservice",
-			wantPromQuery:       `label_values(span_kind)`,
+			wantPromQuery:       `attribute_name(span_kind)`,
 			wantValues:          []string{"SPAN_KIND_SERVER", "SPAN_KIND_CLIENT", "SPAN_KIND_PRODUCER", "SPAN_KIND_CONSUMER"},
 			responsePayloadFile: "testdata/attribute_key_values_response.json",
 			wantError:           false,
@@ -1041,7 +1041,7 @@ func TestGetLabelValues(t *testing.T) {
 			name:          "handle server error",
 			labelName:     "operation_name",
 			serviceName:   "frontend",
-			wantPromQuery: `label_values(operation_name)`,
+			wantPromQuery: `attribute_name(operation_name)`,
 			wantError:     true,
 			errorStatus:   http.StatusInternalServerError,
 		},