Skip to content

Commit 9369223

Browse files
committed
CLOUD-2747 fix http.nonProxyHosts escaping for jws
Signed-off-by: rcernich <[email protected]>
1 parent c3fd77a commit 9369223

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

os-jws-launch/added/launch.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ if [ "${SCRIPT_DEBUG}" = "true" ] ; then
77
log_info "Script debugging is enabled, allowing bash commands and their arguments to be printed as they are executed"
88
fi
99

10+
function escape_catalina_opts() {
11+
local opts=($CATALINA_OPTS)
12+
CATALINA_OPTS=$(printf "%q " ${opts[@]})
13+
}
14+
1015
CONFIGURE_SCRIPTS=(
1116
$JWS_HOME/bin/launch/configure_extensions.sh
1217
$JWS_HOME/bin/launch/passwd.sh
@@ -24,6 +29,7 @@ CONFIGURE_SCRIPTS=(
2429
source $JWS_HOME/bin/launch/configure.sh
2530

2631
CATALINA_OPTS="${CATALINA_OPTS} ${JAVA_PROXY_OPTIONS}"
32+
escape_catalina_opts
2733

2834
log_info "Running $JBOSS_IMAGE_NAME image, version $JBOSS_IMAGE_VERSION"
2935

tests/features/webserver/webserver_tomcat7.feature

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@ Feature: Openshift Tomcat 7 tests
44
@jboss-webserver-3/webserver30-tomcat7-openshift
55
Scenario: Check that the labels are correctly set
66
Given image is built
7-
Then the image should contain label com.redhat.component with value jboss-webserver-3-webserver30-tomcat7-openshift-docker
7+
Then the image should contain label com.redhat.component with value jboss-webserver-3-webserver30-tomcat7-openshift-container
88
And the image should contain label name with value jboss-webserver-3/webserver30-tomcat7-openshift
99
And the image should contain label io.openshift.expose-services with value 8080:http
1010
And the image should contain label io.openshift.tags with value builder,java,tomcat7
1111

1212
@jboss-webserver-3/webserver31-tomcat7-openshift
1313
Scenario: Check that the labels are correctly set
1414
Given image is built
15-
Then the image should contain label com.redhat.component with value jboss-webserver-3-webserver31-tomcat7-openshift-docker
15+
Then the image should contain label com.redhat.component with value jboss-webserver-3-webserver31-tomcat7-openshift-container
1616
And the image should contain label name with value jboss-webserver-3/webserver31-tomcat7-openshift
1717
And the image should contain label io.openshift.expose-services with value 8080:http
1818
And the image should contain label io.openshift.tags with value builder,java,tomcat7

tests/features/webserver/webserver_tomcat8.feature

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@ Feature: Openshift Tomcat 8 tests
44
@jboss-webserver-3/webserver30-tomcat8-openshift
55
Scenario: Check that the labels are correctly set
66
Given image is built
7-
Then the image should contain label com.redhat.component with value jboss-webserver-3-webserver30-tomcat8-openshift-docker
7+
Then the image should contain label com.redhat.component with value jboss-webserver-3-webserver30-tomcat8-openshift-container
88
And the image should contain label name with value jboss-webserver-3/webserver30-tomcat8-openshift
99
And the image should contain label io.openshift.expose-services with value 8080:http
1010
And the image should contain label io.openshift.tags with value builder,java,tomcat8
1111

1212
@jboss-webserver-3/webserver31-tomcat8-openshift
1313
Scenario: Check that the labels are correctly set
1414
Given image is built
15-
Then the image should contain label com.redhat.component with value jboss-webserver-3-webserver31-tomcat8-openshift-docker
15+
Then the image should contain label com.redhat.component with value jboss-webserver-3-webserver31-tomcat8-openshift-container
1616
And the image should contain label name with value jboss-webserver-3/webserver31-tomcat8-openshift
1717
And the image should contain label io.openshift.expose-services with value 8080:http
1818
And the image should contain label io.openshift.tags with value builder,java,tomcat8

0 commit comments

Comments
 (0)