Replace usage of jerryx_print_byte with jerryx_print_buffer.

As we now have JERRY_ZSTR_ARG, so we can take advantage of it

With this, the jerry_port_print_byte port api won't need any more, this reduced the port api surface

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo [email protected]

Author: lygstate

docs/05.PORT-API.md

@@ -116,18 +116,6 @@ void jerry_port_context_free (void);
 void jerry_port_log (const char *message_p);
 ```
 
-```c
-/**
- * Print a single character to standard output.
- *
- * This port function is never called from jerry-core directly, it is only used by jerry-ext components to print
- * information.
- *
- * @param byte: the byte to print.
- */
-void jerry_port_print_byte (jerry_char_t byte);
-```
-
 ```c
 /**
  * Print a buffer to standard output

docs/10.EXT-REFERENCE-HANDLER.md

@@ -351,22 +351,22 @@ jerryx_handler_gc (const jerry_value_t func_obj_val, const jerry_value_t this_p,
 **Summary**
 
 Provide a `print` implementation for scripts. The routine converts all of its
-arguments to strings and outputs them char-by-char using
-`jerry_port_print_byte`. The NULL character is output as "\u0000",
-other characters are output bytewise.
+arguments to strings and outputs them by using `jerry_port_print_buffer`.
+The NULL character is output as "\u0000", other characters are output bytewise.
 
 *Note*: This implementation does not use standard C `printf` to print its
 output. This allows more flexibility but also extends the core JerryScript
 engine port API. Applications that want to use `jerryx_handler_print` must
 ensure that their port implementation also provides
-`jerry_port_print_byte`.
+`jerry_port_print_buffer`.
 
 **Prototype**
 
 ```c
 jerry_value_t
-jerryx_handler_print (const jerry_value_t func_obj_val, const jerry_value_t this_p,
-                      const jerry_value_t args_p[], const jerry_length_t args_cnt);
+jerryx_handler_print (const jerry_call_info_t *call_info_p,
+                      const jerry_value_t args_p[],
+                      const jerry_length_t args_cnt);
 ```
 
 - `func_obj_val` - the function object that was called (unused).
@@ -379,7 +379,7 @@ jerryx_handler_print (const jerry_value_t func_obj_val, const jerry_value_t this
 **See also**
 
 - [jerryx_register_global](#jerryx_register_global)
-- [jerry_port_print_byte](05.PORT-API.md#jerry_port_print_char)
+- [jerry_port_print_buffer](05.PORT-API.md#jerry_port_print_buffer)
 
 
 # Handler registration helper

docs/16.MIGRATION-GUIDE.md

@@ -770,3 +770,4 @@ In this section the new API functions are listed.
 - [`jerry_port_get_current_context`](05.PORT-API.md#jerry_port_get_current_context)
 - [`jerry_port_fatal`](05.PORT-API.md#jerry_port_fatal)
 - [`jerry_port_sleep`](05.PORT-API.md#jerry_port_sleep)
+- [`jerry_port_print_byte`](05.PORT-API.md#jerry_port_print_byte)

jerry-core/include/jerryscript-port.h

@@ -142,16 +142,6 @@ void jerry_port_context_free (void);
  */
 void jerry_port_log (const char *message_p);
 
-/**
- * Print a single character to standard output.
- *
- * This port function is never called from jerry-core directly, it is only used by jerry-ext components to print
- * information.
- *
- * @param byte: the byte to print.
- */
-void jerry_port_print_byte (jerry_char_t byte);
-
 /**
  * Print a buffer to standard output
  *

jerry-ext/include/jerryscript-ext/print.h

@@ -22,7 +22,6 @@
 JERRY_C_API_BEGIN
 
 jerry_value_t jerryx_print_value (const jerry_value_t value);
-void jerryx_print_byte (jerry_char_t ch);
 void jerryx_print_buffer (const jerry_char_t *buffer_p, jerry_size_t buffer_size);
 void jerryx_print_backtrace (unsigned depth);
 void jerryx_print_unhandled_exception (jerry_value_t exception);

jerry-ext/util/handlers.c

@@ -25,17 +25,17 @@
  * Provide a 'print' implementation for scripts.
  *
  * The routine converts all of its arguments to strings and outputs them
- * char-by-char using jerry_port_print_byte.
+ * by using jerry_port_print_buffer.
  *
- * The NUL character is output as "\u0000", other characters are output
+ * The NULL character is output as "\u0000", other characters are output
  * bytewise.
  *
  * Note:
  *      This implementation does not use standard C `printf` to print its
  *      output. This allows more flexibility but also extends the core
  *      JerryScript engine port API. Applications that want to use
  *      `jerryx_handler_print` must ensure that their port implementation also
- *      provides `jerry_port_print_byte`.
+ *      provides `jerry_port_print_buffer`.
  *
  * @return undefined - if all arguments could be converted to strings,
  *         error - otherwise.
@@ -51,7 +51,7 @@ jerryx_handler_print (const jerry_call_info_t *call_info_p, /**< call informatio
   {
     if (index > 0)
     {
-      jerryx_print_byte (' ');
+      jerryx_print_buffer (JERRY_ZSTR_ARG (" "));
     }
 
     jerry_value_t result = jerryx_print_value (args_p[index]);
@@ -62,7 +62,7 @@ jerryx_handler_print (const jerry_call_info_t *call_info_p, /**< call informatio
     }
   }
 
-  jerryx_print_byte ('\n');
+  jerryx_print_buffer (JERRY_ZSTR_ARG ("\n"));
   return jerry_undefined ();
 } /* jerryx_handler_print */
 

jerry-ext/util/print.c

@@ -111,20 +111,6 @@ jerryx_print_value (const jerry_value_t value)
   return jerry_undefined ();
 } /* jerryx_print */
 
-/**
- * Print a character to standard output, also sending it to the debugger, if connected.
- *
- * @param ch: input character
- */
-void
-jerryx_print_byte (jerry_char_t byte)
-{
-  jerry_port_print_byte (byte);
-#if JERRY_DEBUGGER
-  jerry_debugger_send_output (&byte, 1);
-#endif /* JERRY_DEBUGGER */
-} /* jerryx_print_char */
-
 /**
  * Print a buffer to standard output, also sending it to the debugger, if connected.
  *

jerry-ext/util/repl.c

@@ -38,7 +38,7 @@ jerryx_repl (const jerry_char_t *prompt_p, jerry_size_t prompt_size)
 
     if (line_p == NULL)
     {
-      jerryx_print_byte ('\n');
+      jerryx_print_buffer (JERRY_ZSTR_ARG ("\n"));
       return;
     }
 
@@ -80,7 +80,7 @@ jerryx_repl (const jerry_char_t *prompt_p, jerry_size_t prompt_size)
       goto exception;
     }
 
-    jerryx_print_byte ('\n');
+    jerryx_print_buffer (JERRY_ZSTR_ARG ("\n"));
 
     jerry_value_free (result);
     result = jerry_run_jobs ();

jerry-port/common/jerry-port-io.c

@@ -29,17 +29,7 @@ jerry_port_log (const char *message_p) /**< message */
 } /* jerry_port_log */
 
 /**
- * Default implementation of jerry_port_print_byte. Uses 'putchar' to
- * print a single character to standard output.
- */
-void JERRY_ATTR_WEAK
-jerry_port_print_byte (jerry_char_t byte) /**< the character to print */
-{
-  putchar (byte);
-} /* jerry_port_print_byte */
-
-/**
- * Default implementation of jerry_port_print_buffer. Uses 'jerry_port_print_byte' to
+ * Default implementation of jerry_port_print_buffer. Uses 'putchar' to
  * print characters of the input buffer.
  */
 void JERRY_ATTR_WEAK
@@ -48,9 +38,9 @@ jerry_port_print_buffer (const jerry_char_t *buffer_p, /**< string buffer */
 {
   for (jerry_size_t i = 0; i < buffer_size; i++)
   {
-    jerry_port_print_byte (buffer_p[i]);
+    putchar (buffer_p[i]);
   }
-} /* jerry_port_print_byte */
+} /* jerry_port_print_buffer */
 
 /**
  * Read a line from standard input as a zero-terminated string.