Implement optional chaining #5164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergocs
force-pushed
the
optionalChainingFix
branch
4 times, most recently
from
532e122 to
ec873d7
Compare
LaszloLango
requested changes
Nov 19, 2024
Contributor
LaszloLango
left a comment
LaszloLango
left a comment
There was a problem hiding this comment.
I am a little bit worrying about the performance impact of this change. It would nice if we can make sure there is no regression in performance after this change.
gergocs
force-pushed
the
optionalChainingFix
branch
from
ec873d7 to
c65020b
Compare
The work is based on PR jerryscript-project#4843, only fixed some conflicts and cppcheck errors. Co-authored-by: Robert Fancsik [email protected] JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
gergocs
force-pushed
the
optionalChainingFix
branch
from
c65020b to
623f305
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work is based on PR #4843, only fixed some conflicts and cppcheck errors.
Co-authored-by: Robert Fancsik [email protected]
Signed-off-by: Gergo Csizi [email protected]