address change requests and fix build #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
# Conflicts: # bundle/community/manifests/opentelemetry-operator.clusterserviceversion.yaml # bundle/openshift/manifests/opentelemetry-operator.clusterserviceversion.yaml
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
Owner
|
Thanks for updates @frzifus 👍. I cherry-picked most of the commits, except for the Signals removal for now. I'll continue with the conversation in the operator PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClusterObservabilityCRD. All signals are enabled by default: [draft] initial commit for clusterobservability CRD open-telemetry/opentelemetry-operator#4475 (comment)InstrumentationCR: [draft] initial commit for clusterobservability CRD open-telemetry/opentelemetry-operator#4475 (comment)ClusterObservabilityCRD from the bundle: [draft] initial commit for clusterobservability CRD open-telemetry/opentelemetry-operator#4475 (comment)ClusterObservabilityCRD from the docs: [draft] initial commit for clusterobservability CRD open-telemetry/opentelemetry-operator#4475 (comment)InstrumentationandCollectorCRs: [draft] initial commit for clusterobservability CRD open-telemetry/opentelemetry-operator#4475 (comment)