-
Notifications
You must be signed in to change notification settings - Fork 104
Add create accessor factory constructor #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mr7ssam
wants to merge
9
commits into
joanpablo:develop
Choose a base branch
from
mr7ssam:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a75a26a
feat: add simple string accessor
mr7ssam 2e2323e
refactor: remove string accessor and add create instead
mr7ssam 46e3890
refactor: make create factory constructor
mr7ssam 53ae946
refactor: make create factory constructor
mr7ssam 0da2915
Merge remote-tracking branch 'origin/develop' into develop
mr7ssam 4dd6fca
docs: remove string from api doc
mr7ssam 6688443
Merge branch 'joanpablo:develop' into develop
mr7ssam ec3a283
fix: make modelToViewValue and valueToModelValue required
mr7ssam 1891d38
Merge branch 'joanpablo:develop' into develop
mr7ssam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.