Skip to content

Conversation

@laogao
Copy link

@laogao laogao commented May 11, 2023

Connection with issue(s)

Close #377

Solution description

Creates a separate RequiredNonEmptyValidator to cover cases of empty Iterables ,Maps and Sets.

Screenshots or Videos

To Do

  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (711568b) 95.88% compared to head (84e0557) 95.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   95.88%   95.91%   +0.03%     
==========================================
  Files          69       70       +1     
  Lines        1338     1348      +10     
==========================================
+ Hits         1283     1293      +10     
  Misses         55       55              
Impacted Files Coverage Δ
lib/src/validators/required_validator.dart 100.00% <ø> (ø)
...b/src/validators/required_non_empty_validator.dart 100.00% <100.00%> (ø)
lib/src/validators/validators.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RequiredValidator to flag empty lists and maps in addition to nulls and empty strings

1 participant