For insecure-cors, always return Access-Control-Allow-Origin. #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per MDN [1], we should always return Access-Control-Allow-Origin, not just on preflight requests. 1. https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/CORS#simple_requests Co-authored-by: Blake Williams <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per MDN [1], we should always return Access-Control-Allow-Origin, not just on preflight requests. I have a simple frontend app that gets a presigned S3 URL and then attempts to push a file to S3, but i was getting the following error in my browser console:
Making this change solved the error for me. Many thanks to @shabbyrobe who coached me through it!