Fix PHP 8.5 deprecations

Since PHP 8.1, calling the Reflection*::setAccessible() methods is no longer necessary as reflected properties/methods/etc will always be accessible. However, the method calls are still needed for PHP < 8.1.

As of PHP 8.5, calling the Reflection*::setAccessible() methods is now formally deprecated and will yield a deprecation notice, which will fail test runs. As of PHP 9.0, the setAccessible() method(s) will be removed.

Silencing the deprecation would mean, this would need to be "fixed" again come PHP 9.0, while the current solution should be stable, including for PHP 9.0.

Ref: https://wiki.php.net/rfc/deprecations_php_8_5#extreflection_deprecations

Fixes #1025

Author: Pross

classes/Collector_Assets.php

@@ -283,13 +283,13 @@ protected static function get_script_modules(): ?array {
 		$reflector = new ReflectionClass( $modules );
 
 		$get_marked_for_enqueue = $reflector->getMethod( 'get_marked_for_enqueue' );
-		$get_marked_for_enqueue->setAccessible( true );
+		(\PHP_VERSION_ID < 80100) and $get_marked_for_enqueue->setAccessible( true );
 
 		$get_dependencies = $reflector->getMethod( 'get_dependencies' );
-		$get_dependencies->setAccessible( true );
+		(\PHP_VERSION_ID < 80100) and $get_dependencies->setAccessible( true );
 
 		$get_src = $reflector->getMethod( 'get_src' );
-		$get_src->setAccessible( true );
+		(\PHP_VERSION_ID < 80100) and $get_src->setAccessible( true );
 
 		/**
 		 * @var array<string, array<string, mixed>> $enqueued
@@ -365,9 +365,9 @@ protected static function get_script_modules(): ?array {
 		}
 
 		// @todo check isPrivate before changing visibility back
-		$get_marked_for_enqueue->setAccessible( false );
-		$get_dependencies->setAccessible( false );
-		$get_src->setAccessible( false );
+		(\PHP_VERSION_ID < 80100) and $get_marked_for_enqueue->setAccessible( false );
+		(\PHP_VERSION_ID < 80100) and $get_dependencies->setAccessible( false );
+		(\PHP_VERSION_ID < 80100) and $get_src->setAccessible( false );
 
 		return $sources;
 	}