return 410 Gone for deleted identity

Author: alphatownsman

activities/models/fan_out.py

@@ -241,6 +241,8 @@ def handle_new(cls, instance: "FanOut"):
                     )
                 except httpx.RequestError:
                     return
+                except ValueError:
+                    pass # do not retry if 4xx
 
             # Handle sending identity moved to remote
             case (FanOut.Types.identity_moved, False):

users/models/identity.py

@@ -55,7 +55,7 @@ class IdentityStates(StateGraph):
 
     edited = State(try_interval=300, attempt_immediately=True)
     deleted = State(try_interval=300, attempt_immediately=True)
-    deleted_fanned_out = State(delete_after=86400 * 7)
+    deleted_fanned_out = State(externally_progressed=True)
 
     moved = State(try_interval=300, attempt_immediately=True)
     moved_fanned_out = State(externally_progressed=True)
@@ -582,7 +582,7 @@ def to_ap(self):
         self.ensure_uris()
         response = {
             "id": self.actor_uri,
-            "type": self.actor_type.title(),
+            "type": "Tombstone" if self.deleted else self.actor_type.title(),
             "inbox": self.inbox_uri,
             "outbox": self.outbox_uri,
             "featured": self.featured_collection_uri,

users/views/identity.py

@@ -64,10 +64,13 @@ def serve_actor(self, identity):
         # If this not a local actor, redirect to their canonical URI
         if not identity.local:
             return redirect(identity.actor_uri)
-        return JsonResponse(
+        r = JsonResponse(
             canonicalise(identity.to_ap(), include_security=True),
             content_type="application/activity+json",
         )
+        if identity.deleted:
+            r.status_code = 410
+        return r
 
     def get_queryset(self):
         return TimelineService(None).identity_public(