Summary
PR #910 added a significant sidecar execution path to the QEMU driver (launcher_socket, _wrap_command, socket-based serial/console), but driver unit tests and README documentation for that mode were deferred.
Background
From PR #910:
Driver test and README updates for sidecar mode will be tracked in a follow-up PR — this PR is already quite large.
Original review note: missing test/README updates.
What needs to be done
- Add unit tests in
jumpstarter_driver_qemu/driver_test.py covering:
_wrap_command / launcher socket mode
_work_dir / shared-volume path branching
- serial/console behavior when running via
jumpstarter-exec
- Update
jumpstarter-driver-qemu README with sidecar-mode configuration (launcher_socket, shared volume paths, ExporterSet usage)
- Prefer e2e-style coverage where practical (server + client), mock only when system tooling makes that unreliable
Acceptance criteria
Tracking
Summary
PR #910 added a significant sidecar execution path to the QEMU driver (
launcher_socket,_wrap_command, socket-based serial/console), but driver unit tests and README documentation for that mode were deferred.Background
From PR #910:
Original review note: missing test/README updates.
What needs to be done
jumpstarter_driver_qemu/driver_test.pycovering:_wrap_command/ launcher socket mode_work_dir/ shared-volume path branchingjumpstarter-execjumpstarter-driver-qemuREADME with sidecar-mode configuration (launcher_socket, shared volume paths, ExporterSet usage)Acceptance criteria
make pkg-test-jumpstarter-driver-qemu)docs/source/reference/package-apis/drivers/stays accurate if README changesTracking
python/packages/jumpstarter-driver-qemu/