Skip to content

Commit 78a63d1

Browse files
committed
Fix compat with RubyInstaller-2.4 on Windows (brianmario#875)
Since RubyInstaller-2.4+ is bundled with MSYS2 and the libmariadbclient can be installed per gemspec library dependency, it is easy to build the mysql2 gem in Windows. The MSYS2/MINGW dependency feature is documented here: https://github.com/oneclick/rubyinstaller2/wiki/For-gem-developers#msys2-library-dependency This also adds ruby-2.4 binaries, so that the mysql2 is still usabel as a binary gem. Fixes brianmario#861 The change in the spec is required for mariadbclient. It throws an error if no query was executed. Due to the stdcall convention on i686, the mysql_query() function check fails, so that it is omitted, now. Signed-off-by: Jun Aruga <[email protected]>
1 parent 235eaa4 commit 78a63d1

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

spec/mysql2/statement_spec.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -731,7 +731,6 @@ def stmt_count
731731

732732
it 'should return number of rows affected by an insert' do
733733
stmt = @client.prepare 'INSERT INTO lastIdTest (blah) VALUES (?)'
734-
expect(stmt.affected_rows).to eq 0
735734
stmt.execute 1
736735
expect(stmt.affected_rows).to eq 1
737736
end

0 commit comments

Comments
 (0)